tianxiaoliang commented on code in PR #1309: URL: https://github.com/apache/servicecomb-service-center/pull/1309#discussion_r914779527
########## istio/examples/consumer-provider/Readme.md: ########## @@ -0,0 +1,70 @@ +# Context +We have two services: Provider and Consumer: +* `provider` is the provider of a service which calculates and returns the sum of the square root from 1 to a user provided parameter `x`. +* `consumer` performs as both provider and consumer. As a consumer, it calls the api provided by `provider` to get the result of the sum of square roots; +as a `provider`, it provides a service externally which returns the result it gets from `provider` to its clients. + +While Provider uses servicecomb service center tech stack, Consumer uses istio tech stack. Origionaly, Provider and Consumer couldn't discover each other. + +In this demo, we are going to adopt our servicecomb-service-center-istio to brake the barrier between Provider and Consumer. + +The logical network and calling relationship of the Provider and Consumer is as follows： + + + +# Pre-use preparation +Please follow [user-guide](../../docs/user_guide.md) to install all the required environment as well as the servicecomb-service-center-istio tool. + +# Build Provider and Consumer service +## Consumer +``` +# go to consumer folder and run +> go build -o consumer main.go Review Comment: please use docker multi-stage build to improve the ux ########## istio/examples/consumer-provider/Readme.md: ########## @@ -0,0 +1,70 @@ +# Context Review Comment: this "docs/user-guides/integration-istio.md" is imcomplete, as a user my task is not just running a system proccess. please merge this part to docs/user-guides/integration-istio.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
