tianxiaoliang commented on code in PR #1309: URL: https://github.com/apache/servicecomb-service-center/pull/1309#discussion_r917726744
########## istio/pkg/controllers/servicecenter/connector.go: ########## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package servicecenter + +import ( + "sync" + "time" + + "github.com/apache/servicecomb-service-center/istio/pkg/event" + + "github.com/go-chassis/cari/discovery" + "github.com/go-chassis/sc-client" + "istio.io/pkg/log" +) + +const ( + // Time in seconds to wait before re-registering a deleted Servicecomb Service Center Watcher service + REREGISTER_INTERVAL time.Duration = time.Second * 5 +) + +// Servicecomb Service Center go-chassis client +type Connector struct { + client *sc.Client + cacheMutex sync.Mutex + AppInstanceWatcherCache map[string]string // Maps appId to id of a instance watcher service. Need app-specific watchers to avoid cross-app errors. Review Comment: use syc.Map ########## istio/pkg/event/event.go: ########## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package event + +// Common interface for convertable service and instance structs used by Service center and Istio APIs. +type Event interface { Review Comment: Event shouldn't has ability to convet himself to another Event. plz use EntryTransformer.Transfer(e Entry) to decouple with different entries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
