liubao68 commented on code in PR #4095:
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/4095#discussion_r1416733647


##########
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/VertxUtils.java:
##########
@@ -85,16 +86,16 @@ public static <CLIENT_POOL> DeploymentOptions 
createClientDeployOptions(
   }
 
   // deploy Verticle and wait for its success. do not call this method in 
event-loop thread
-  public static <VERTICLE extends Verticle> boolean blockDeploy(Vertx vertx,
+  public static <VERTICLE extends Verticle> Map<String, String> 
blockDeploy(Vertx vertx,

Review Comment:
   return `Map<String, Object>` to avoid data type convert



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to