little-cui commented on code in PR #1467:
URL:
https://github.com/apache/servicecomb-service-center/pull/1467#discussion_r1562223866
##########
syncer/config/config.go:
##########
@@ -44,28 +46,32 @@ type Peer struct {
Mode []string `yaml:"mode"`
}
-func Init() error {
- err := archaius.AddFile(filepath.Join(util.GetAppRoot(), "conf",
"syncer.yaml"))
+func Init() (error, bool) {
+ err := archaius.AddFile(filepath.Join(util.GetAppRoot(), "conf",
"syncer", "syncer.yaml"))
if err != nil {
log.Warn(fmt.Sprintf("can not add syncer config file source,
error: %s", err))
- return err
+ return err, false
}
- err = Reload()
+ err, isRefresh := Reload()
Review Comment:
不需要定期刷新，go-chassis集成了动态配置框架go-archaius，使用方式如下
endpoint = archaius.GetString("syncer.endpoint", "")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
