anthonyx24 opened a new issue, #4968:
URL: https://github.com/apache/servicecomb-java-chassis/issues/4968

   ### Steps to Reproduce
   
   ### Steps to Reproduce
   
   This is the same issue as #4946 for a different class, since there is also a 
JSON string comparison here. In summary, since JSONs are unordered, after 
converting them to strings, the parameter ordering is not guaranteed. For 
another example of this issue being addressed, see this [previous merged 
PR](https://github.com/apache/servicecomb-java-chassis/pull/4633).
   
   This test was flagged via the 
[NonDex](https://github.com/TestingResearchIllinois/NonDex) tool, which detects 
potentially unreliable tests due to underlying Java API assumptions. To see the 
Nondex output for this test, you can run:
   
   ```
   mvn -pl metrics/metrics-core edu.illinois:nondex-maven-plugin:2.1.7:nondex 
-Dtest="org.apache.servicecomb.metrics.core.publish.TestThreadPoolPublishModelFactory#createDefaultPublishModel"
   ```
   
   ### Expected Behavior
   
   The test should pass regardless of JSON parameter ordering, since it's just 
checking that the object was created with the right initial values.
   
   ### Servicecomb Version
   
   3.3.0
   
   ### Additional Context
   
   I have a potential fix in a PR, I'll be adding that to the discussion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to