anthonyx24 opened a new pull request, #4994:
URL: https://github.com/apache/servicecomb-java-chassis/pull/4994

   **Issue**: See #4993. To summarize, since the `groups` HashMap is unordered, 
using `Matchers.contains`, which does strict order checking, can result in a 
test failure since the key iteration order isn't guaranteed.
   
   **Fix:** I simply replace `Matchers.contains` with 
[`Matchers.containsInAnyOrder`](https://hamcrest.org/JavaHamcrest/javadoc/1.3/org/hamcrest/Matchers.html#containsInAnyOrder(T...)),
 since it doesn't do strict order checking. 
   
   **PR Checklist:**
    - [x] Github Issue: 
https://github.com/apache/servicecomb-java-chassis/issues/4993
    - [x] Each commit in the pull request should have a meaningful subject line 
and body.
    - [x] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
    - [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [x] Run `mvn clean install -Pit` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to