chengyouling commented on code in PR #5019:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/5019#discussion_r2554546919
##########
clients/http-client-common/src/main/java/org/apache/servicecomb/http/client/common/HttpTransportImpl.java:
##########
@@ -98,9 +99,15 @@ public HttpResponse doRequest(HttpRequest httpRequest)
throws IOException {
response.getAllHeaders());
}
- private static SignRequest createSignRequest() {
- // Now the implementations do not process SignRequest, so return null.
Maybe future will use it.
- return null;
+ private static SignRequest createSignRequest(String url) {
+ try {
+ URI uri = URI.create(url);
+ SignRequest signRequest = new SignRequest();
+ signRequest.setEndpoint(uri);
+ return signRequest;
+ } catch (Exception e) {
+ return null;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
