Author: rbaxter85
Date: Tue Jun 24 20:14:20 2014
New Revision: 1605172

URL: http://svn.apache.org/r1605172
Log:
The gadget loaded by Shindig doesn't contain proper title element
SHINDIG-1978
Committed For Jiaqing Guo

Modified:
    
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java

Modified: 
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java
URL: 
http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java?rev=1605172&r1=1605171&r2=1605172&view=diff
==============================================================================
--- 
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java
 (original)
+++ 
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java
 Tue Jun 24 20:14:20 2014
@@ -61,6 +61,7 @@ import org.apache.shindig.gadgets.rewrit
 import org.apache.shindig.gadgets.rewrite.RewritingException;
 import org.apache.shindig.gadgets.spec.Feature;
 import org.apache.shindig.gadgets.spec.MessageBundle;
+import org.apache.shindig.gadgets.spec.ModulePrefs;
 import org.apache.shindig.gadgets.spec.UserPref;
 import org.apache.shindig.gadgets.spec.View;
 import org.apache.shindig.gadgets.templates.MessageELResolver;
@@ -240,6 +241,14 @@ public class RenderingGadgetRewriter imp
       // Insert new content before any of the existing children of the head 
element
       Node firstHeadChild = head.getFirstChild();
 
+      ModulePrefs mps = gadget.getSpec().getModulePrefs();
+      if (mps != null && mps.getTitle() != null && !mps.getTitle().isEmpty()
+          && !"".equals(mps.getTitle().trim())) {
+        Element title = document.createElement("title");
+        
title.appendChild(title.getOwnerDocument().createTextNode(mps.getTitle().trim()));
+        head.insertBefore(title, firstHeadChild);
+      }
+
       Element injectedStyle = document.createElement("style");
       injectedStyle.setAttribute("type", "text/css");
       head.insertBefore(injectedStyle, firstHeadChild);


Reply via email to