bdemers commented on a change in pull request #287:
URL: https://github.com/apache/shiro/pull/287#discussion_r599045733
##########
File path:
web/src/main/java/org/apache/shiro/web/session/HttpServletSession.java
##########
@@ -83,7 +83,8 @@ public long getTimeout() throws InvalidSessionException {
public void setTimeout(long maxIdleTimeInMillis) throws
InvalidSessionException {
try {
- int timeout = Long.valueOf(maxIdleTimeInMillis / 1000).intValue();
+ long ltimeout = maxIdleTimeInMillis / 1000;
+ int timeout = (int)ltimeout;
Review comment:
I appreciate the SonarCloud link, but we need to embed the info in the
commit message (the SonarCloud content could be removed at some point in the
future, so we would need to provide the same context in the commit message
directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
