bmarwell commented on a change in pull request #297:
URL: https://github.com/apache/shiro/pull/297#discussion_r626701474
##########
File path: pom.xml
##########
@@ -1533,6 +1533,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-invoker-plugin</artifactId>
+ <version>3.2.2</version>
Review comment:
Good option!
##########
File path: Jenkinsfile-jdk11
##########
@@ -72,14 +72,15 @@ pipeline {
stage('Build') {
steps {
echo 'Building'
- sh 'mvn -U -B -e clean install -DskipTests apache-rat:check'
+ sh 'mvn -U -B -e apache-rat:check'
+ sh 'mvn -U -B -e ${MVN_LOCAL_REPO_OPT} clean install
-DskipTests'
Review comment:
Is install really needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
