rgcv opened a new pull request, #2224: URL: https://github.com/apache/shiro/pull/2224
<!-- For Security Vulnerabilities, please email: [email protected] For more details on how to report a vulnerablity see: https://www.apache.org/security/ --> Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GitHub issue](https://github.com/apache/shiro/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[#XXX] - Fixes bug in SessionManager`, where you replace `#XXX` with the appropriate GitHub issue. Best practice is to use the GitHub issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] add `fixes #XXX` if merging the PR should close a related issue. - [x] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [ ] Committers: Make sure a milestone is set on the PR Trivial changes like typos do not require a GitHub issue (javadoc, comments...). In this case, just format the pull request title like `[DOC] - Add javadoc in SessionManager`. If this is your first contribution, you have to read the [Contribution Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md) If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- Based on the overall complex changes introduced by #2017 (and discussion within it) and #2018, I decided to open a more concise PR that runs the [OpenRewrite Jakarta EE 10 migration recipe](https://docs.openrewrite.org/recipes/java/migrate/jakarta/jakartaee10). As a result, the base commit is the changeset introduced by applying the recipe. Surrounding commits handle a few things manually, such as - Removing the `jakarta` classifier from shiro artifacts + shade-plugin configuration - Tackle minor `checkstyle` issues resulting from the migration - Remove deprecated `HttpSessionContext` polyfill and related code (gone in EE10) - Removed some stray duplicate jax-rs dependency declarations - Temporarily(!) disable some support modules, integration tests, and samples Regarding the last bullet point, perhaps even per supported module/feature-set, a few more changes are required. Plus, some decisions might want to be made before proceeding with migration, namely: - Are we still supporting such integrations? (E.g., ehcache, which would need a major bump, as seen in #2018; guice, which is already on v7; spring(-boot) which require a major bump _and_ java 17, etc.) - Should this PR be worked on iteratively? (there are a few more OpenRewrite recipes worth exploring. Notoriously, spring-boot migration recipes also include quite a few gems such as java 17 uplift, and the Jakarta EE10 one, which was already applied) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
