fpapon commented on code in PR #2326:
URL: https://github.com/apache/shiro/pull/2326#discussion_r2448822632
##########
tools/hasher/src/main/java/org/apache/shiro/tools/hasher/Hasher.java:
##########
@@ -255,10 +254,9 @@ public static void main(String[] args) {
} else {
iterations = DEFAULT_NUM_ITERATIONS;
}
- } else {
- //Iterations were specified, so add the iterations parameter:
-
parameters.put(SimpleHashProvider.Parameters.PARAMETER_ITERATIONS, iterations);
}
+ //Iterations were specified, so add the iterations parameter:
Review Comment:
For me this not correct because we want to insure that the iterations
parameter specified by the user is not too weak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
