lprimak commented on code in PR #2372: URL: https://github.com/apache/shiro/pull/2372#discussion_r2535171210
########## web/src/main/java/org/apache/shiro/web/util/CorsUtils.java: ########## @@ -0,0 +1,54 @@ +package org.apache.shiro.web.util; + +import org.apache.shiro.lang.util.StringUtils; + +import javax.servlet.http.HttpServletRequest; + +/** + * Utility class for CORS request handling based on the W3. + * + * @see <a href="https://fetch.spec.whatwg.org/#http-cors-protocol";>CORS W3C recommendation</a> + * @since 2.0.6 + */ +public abstract class CorsUtils { Review Comment: This really is not an abstract class. You can make it an interface or a final non-abstract class, which should yield the same result. I prefer an interface in instances like this. ########## web/src/main/java/org/apache/shiro/web/util/CorsUtils.java: ########## @@ -0,0 +1,54 @@ +package org.apache.shiro.web.util; + +import org.apache.shiro.lang.util.StringUtils; + +import javax.servlet.http.HttpServletRequest; Review Comment: Needs copyright -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
