boris-petrov commented on PR #2485: URL: https://github.com/apache/shiro/pull/2485#issuecomment-3873381779
I haven't looked in details at the implementation but wouldn't it be better if there were a couple of new classes like `ScopedValuesCallable` and `ScopedValuesRunnable` which would extend `SubjectCallable`/`SubjectRunnable` (or perhaps even directly `Callable`/`Runnable`)? And then at the instantiation site choose which one is appropriate? Not sure if that would make sense and if it would make the code "better"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
