steinarb commented on code in PR #2800:
URL: https://github.com/apache/shiro/pull/2800#discussion_r3447377059
##########
core/src/main/java/org/apache/shiro/mgt/AbstractRememberMeManager.java:
##########
@@ -66,16 +74,32 @@
* @since 0.9
*/
public abstract class AbstractRememberMeManager implements RememberMeManager {
+ protected record RememberedIdentity(PrincipalCollection principals,
Instant creationTime) implements Serializable {
Review Comment:
Not sure if records behaves like classes here, but maybe this should be
```
protected static record
```
if this is supposed to be a record scoped by the surrounding class but
otherwise behaving as a regular record?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
