Nexory commented on PR #2832: URL: https://github.com/apache/shiro/pull/2832#issuecomment-4964985020
Thanks @lprimak, all addressed in a new commit (no force-push): - **`@since` -> `3.0.1`** everywhere (`Serializer`, `DefaultSerializer`, `AbstractRememberMeManager`). - **Pulled the filter API up into `Serializer`**: `getObjectInputFilter()` / `setObjectInputFilter(...)` are now default methods on the interface (getter returns `null`, setter is a no-op), and `DefaultSerializer` `@Override`s them. Since an interface can't hold the filter field, the state stays in `DefaultSerializer`; non-Java-serialization `Serializer` implementations just inherit the no-op default and are unaffected. Happy to make them abstract instead if you'd prefer, though that would be a breaking change for existing `Serializer` implementors. - With the API on `Serializer`, `AbstractRememberMeManager` now calls `serializer.setObjectInputFilter(DEFAULT_OBJECT_INPUT_FILTER)` directly, so the `instanceof`, the cast, and the `@SuppressWarnings` are all gone. The documented override example and the test dropped their casts too, no checkstyle suppression needed. Rebuilt locally: `shiro-lang` and `shiro-core` suites green, checkstyle and pre-commit clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
