lprimak opened a new pull request, #2901:
URL: https://github.com/apache/shiro/pull/2901
## Description
### Configure Apache RAT to run once from the repository root instead of in
every module.
- RAT plugin is not thread-safe, maven parallel builds did not work
consistently
- Disable submodule-inherited RAT executions, only root module will run it
now
- Make sure RAT check runs for all submodules from root, improving execution
speed
- Centralize RAT exclusions, removing having to duplicate lots of exclusion
entries
- Preserve an explicit `rat.skip` property for controlling the root RAT
check.
- Preserve ability to use `mvn apache-rat:check` on the command line.
### Configure Japicmp to automatically compare against the latest major
release.
- Make sure Japicmp plugin doesn't use hardcoded release to compare against
- Preserved (commented out) hardcoded configuration, if necessary in the
future
- Now takes the latest major release (x.0.0) instead of a hardcoded release
### SLF4j in Meecrowave IT tests: use common version variable instead of
explicit version
- Use the shared `${slf4j.version}` property for the Meecrowave support
module.
### Update to the latest Selenium for Jakarta EE tests
- Import the Selenium BOM (latest versions) for Jakarta EE integration tests.
---
Following this checklist to help us incorporate your contribution quickly
and easily:
- [ ] Make sure there is a [GitHub
issue](https://github.com/apache/shiro/issues) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a GitHub issue. Your pull request should address just this
issue, without pulling in other changes.
- [ ] Format the pull request title like `[#XXX] - Fixes bug in
SessionManager`,
where you replace `#XXX` with the appropriate GitHub issue. Best
practice
is to use the GitHub issue title in the pull request title and in the
first line of the commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] add `fixes #XXX` if merging the PR should close a related issue.
- [ ] Run `mvn verify` to make sure basic checks pass. A more thorough
check will be performed on your pull request automatically.
- [ ] Committers: Make sure a milestone is set on the PR
- [ ] Committers: Use "Squash and Merge" to combine all commits into one
when merging a PR when appropriate.
Trivial changes like typos do not require a GitHub issue (javadoc,
comments...).
In this case, just format the pull request title like `[DOC] - Add javadoc
in SessionManager`.
If this is your first contribution, you have to read the [Contribution
Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md)
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
