This is an automated email from the ASF dual-hosted git repository.
lprimak pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/shiro.git
The following commit(s) were added to refs/heads/main by this push:
new 11d5bd9d1 Improve build stability: RAT, Selenium and JavaAPI
Comparison enforcer plugin (#2901)
11d5bd9d1 is described below
commit 11d5bd9d168c378873988dbc8871e156a50e644b
Author: Lenny Primak <[email protected]>
AuthorDate: Thu Oct 1 13:16:45 2026 -0500
Improve build stability: RAT, Selenium and JavaAPI Comparison enforcer
plugin (#2901)
* chore: moved meecrowave slf4j into a variable
* added selenium BOM
* RAT check: run only at root of the tree
---
integration-tests/jakarta-ee/pom.xml | 7 ++++
integration-tests/meecrowave-support/pom.xml | 2 +-
pom.xml | 57 ++++++++++------------------
3 files changed, 28 insertions(+), 38 deletions(-)
diff --git a/integration-tests/jakarta-ee/pom.xml
b/integration-tests/jakarta-ee/pom.xml
index b8924512b..fc9118d99 100644
--- a/integration-tests/jakarta-ee/pom.xml
+++ b/integration-tests/jakarta-ee/pom.xml
@@ -147,6 +147,13 @@
<artifactId>payara-micro</artifactId>
<version>${payara.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.seleniumhq.selenium</groupId>
+ <artifactId>selenium-bom</artifactId>
+ <version>4.49.0</version>
+ <scope>import</scope>
+ <type>pom</type>
+ </dependency>
</dependencies>
</dependencyManagement>
diff --git a/integration-tests/meecrowave-support/pom.xml
b/integration-tests/meecrowave-support/pom.xml
index c367a262a..a3068901c 100644
--- a/integration-tests/meecrowave-support/pom.xml
+++ b/integration-tests/meecrowave-support/pom.xml
@@ -61,7 +61,7 @@
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>jcl-over-slf4j</artifactId>
- <version>2.0.20</version>
+ <version>${slf4j.version}</version>
<scope>runtime</scope>
</dependency>
diff --git a/pom.xml b/pom.xml
index ca6453c6d..4afe47ad0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -66,12 +66,11 @@
</distributionManagement>
<properties>
- <!-- *** Remove the line below when 3.0.0 is released -->
- <shiro.previousVersion>3.0.0</shiro.previousVersion>
<!-- Replaced by the build number plugin at build time: -->
<buildNumber>${user.name}-${maven.build.timestamp}</buildNumber>
<project.build.outputTimestamp>2026-02-07T22:56:07Z</project.build.outputTimestamp>
<root.dir>${maven.multiModuleProjectDirectory}</root.dir>
+ <rat.skip>false</rat.skip>
<jacoco.skip>true</jacoco.skip>
<japicmp-skip>false</japicmp-skip>
<japicmp.skip>${japicmp-skip}</japicmp.skip>
@@ -330,16 +329,18 @@
</dependency>
</dependencies>
</plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-site-plugin</artifactId>
- <version>4.0.0-M16</version>
- </plugin>
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<configuration>
- <!-- note that this configuration needs to be
maintained both in pluginManagement and reporting sections -->
+ <!-- also applied to the RAT report in <reporting> -->
+ <!--
+ RAT is not thread-safe in parallel (-T / mvnd)
builds (shared .gitignore parser and
+ license matchers), so it is skipped in modules and
runs once at the root,
+ scanning the whole tree. This also covers
command-line "apache-rat:check" runs.
+ -->
+ <skip>true</skip>
+ <excludeSubProjects>false</excludeSubProjects>
<inputExcludes>
<inputExclude>**/.externalToolBuilders/*</inputExclude>
<inputExclude>**/infinitest.filters</inputExclude>
@@ -440,15 +441,18 @@
<artifactId>japicmp-maven-plugin</artifactId>
<version>0.26.2</version>
<configuration>
+ <!-- If specific old version is needed, uncomment the
following and set the version to compare against
<oldVersion>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>${project.artifactId}</artifactId>
- <version>${shiro.previousVersion}</version>
+ <version>3.0.0</version>
<type>jar</type>
</dependency>
</oldVersion>
+ -->
<parameter>
+ <oldVersionPattern>\d+\.0\.0</oldVersionPattern>
<onlyModified>true</onlyModified>
<breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications>
<breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications>
@@ -538,6 +542,11 @@
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
+ <!-- only run at the root, see pluginManagement -->
+ <inherited>false</inherited>
+ <configuration>
+ <skip>${rat.skip}</skip>
+ </configuration>
<executions>
<execution>
<id>rat-check</id>
@@ -1412,36 +1421,10 @@
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
- <!-- only run at the root -->
<inherited>false</inherited>
+ <!-- configuration is inherited from build/pluginManagement -->
<configuration>
- <!-- note that this configuration needs to be maintained
both in pluginManagement and reporting sections -->
- <inputExcludes>
- <inputExclude>**/.externalToolBuilders/*</inputExclude>
- <inputExclude>**/infinitest.filters</inputExclude>
- <!-- Apparently some test in samples/spring-client
generates velocity log - would better to reconfigure to output to target/ -->
- <inputExclude>velocity.log</inputExclude>
- <inputExclude>CONTRIBUTING.md</inputExclude>
- <inputExclude>AGENTS.md</inputExclude>
- <inputExclude>SECURITY.md</inputExclude>
- <inputExclude>**/README.md</inputExclude>
- <inputExclude>**/*.json</inputExclude>
- <inputExclude>**/spring.factories</inputExclude>
-
<inputExclude>**/org.springframework.boot.autoconfigure.AutoConfiguration.imports</inputExclude>
- <inputExclude>**/spring.provides</inputExclude>
- <inputExclude>**/*.iml</inputExclude>
- <inputExclude>**/*.idea/**</inputExclude>
- <inputExclude>**/target/**</inputExclude>
- <inputExclude>**/nb-configuration.xml</inputExclude>
- <inputExclude>**/faces-config.NavData</inputExclude>
- <inputExclude>**/.project</inputExclude>
- <inputExclude>**/.classpath</inputExclude>
- <inputExclude>**/.settings/*</inputExclude>
-
<inputExclude>.github/linters/codespell.txt</inputExclude>
-
<inputExclude>**/org.mockito.plugins.MockMaker</inputExclude>
- <inputExclude>.mvn/*</inputExclude>
- <inputExclude>.jenkins_maven_args</inputExclude>
- </inputExcludes>
+ <skip>${rat.skip}</skip>
</configuration>
</plugin>
<plugin>