This is an automated email from the ASF dual-hosted git repository.
desruisseaux pushed a commit to branch geoapi-4.0
in repository https://gitbox.apache.org/repos/asf/sis.git
The following commit(s) were added to refs/heads/geoapi-4.0 by this push:
new 831f789 Add link to SIS-455. This issue is not going to be fixed now.
831f789 is described below
commit 831f789cd9d139f462327c6523440b9c881f154a
Author: Martin Desruisseaux <[email protected]>
AuthorDate: Fri May 24 10:44:35 2019 +0200
Add link to SIS-455. This issue is not going to be fixed now.
---
.../src/main/java/org/apache/sis/internal/referencing/j2d/Bezier.java | 3 +++
.../src/main/java/org/apache/sis/referencing/GeodeticCalculator.java | 2 ++
2 files changed, 5 insertions(+)
diff --git
a/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/j2d/Bezier.java
b/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/j2d/Bezier.java
index 78694c5..464f8a4 100644
---
a/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/j2d/Bezier.java
+++
b/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/j2d/Bezier.java
@@ -144,6 +144,8 @@ public abstract class Bezier {
*
* @todo This method is a hack. We should replace it by a computation of
the Bézier <var>t</var> parameter
* of the point closest to the given (x₁,y₁) and (x₃,y₃) points.
+ *
+ * @see <a href="https://issues.apache.org/jira/browse/SIS-455";>SIS-455</a>
*/
protected boolean isValid(double x, double y) throws TransformException {
return false;
@@ -383,6 +385,7 @@ public abstract class Bezier {
* fixed t values. If we want to improve on that in a future
version, we would need a function for computing
* arc length (for example based on
https://pomax.github.io/bezierinfo/#arclength), then use iterative method
* like
https://www.geometrictools.com/Documentation/MovingAlongCurveSpecifiedSpeed.pdf
(retrieved May 2019).
+ * See https://issues.apache.org/jira/browse/SIS-455 for more
information.
*
* Instead we perform another test using the tangent of the
curve at point P₁ (and later P₃).
*
diff --git
a/core/sis-referencing/src/main/java/org/apache/sis/referencing/GeodeticCalculator.java
b/core/sis-referencing/src/main/java/org/apache/sis/referencing/GeodeticCalculator.java
index 5123b3b..1bb659d 100644
---
a/core/sis-referencing/src/main/java/org/apache/sis/referencing/GeodeticCalculator.java
+++
b/core/sis-referencing/src/main/java/org/apache/sis/referencing/GeodeticCalculator.java
@@ -801,6 +801,8 @@ public class GeodeticCalculator {
* Returns whether the point at given (<var>x</var>, <var>y</var>)
coordinates is close to the geodesic path.
* This method is invoked when the {@link Bezier} helper class thinks
that the point is not on the path, but
* could be wrong because of the difficulty to evaluate the Bézier
<var>t</var> parameter of closest point.
+ *
+ * @see <a
href="https://issues.apache.org/jira/browse/SIS-455";>SIS-455</a>
*/
@Override
protected boolean isValid(final double x, final double y) throws
TransformException {
