This is an automated email from the ASF dual-hosted git repository.

desruisseaux pushed a commit to branch geoapi-4.0
in repository https://gitbox.apache.org/repos/asf/sis.git

commit 1638e577918b65396158d726fe4796a16b6e28d6
Author: Martin Desruisseaux <martin.desruisse...@geomatys.com>
AuthorDate: Wed Aug 10 16:26:04 2022 +0200

    Complete documentation and remove an exclusion for a test which now passes.
---
 .../provider/GeocentricToTopocentric.java          | 24 ++++++++++++++++++++++
 .../provider/GeographicToTopocentric.java          | 20 ++++++++++++++++++
 .../sis/test/integration/ConsistencyTest.java      |  3 +--
 3 files changed, 45 insertions(+), 2 deletions(-)

diff --git 
a/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/provider/GeocentricToTopocentric.java
 
b/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/provider/GeocentricToTopocentric.java
index b298be87ed..18141bea9f 100644
--- 
a/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/provider/GeocentricToTopocentric.java
+++ 
b/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/provider/GeocentricToTopocentric.java
@@ -60,6 +60,14 @@ public final class GeocentricToTopocentric extends 
AbstractProvider {
      * The operation parameter descriptor for the <cite>Geocentric X of 
topocentric origin</cite> (X) parameter value.
      *
      * <!-- Generated by ParameterNameTableGenerator -->
+     * <table class="sis">
+     *   <caption>Parameter names</caption>
+     *   <tr><td> EPSG:    </td><td> Geocentric X of topocentric origin 
</td></tr>
+     * </table>
+     * <b>Notes:</b>
+     * <ul>
+     *   <li>No default value</li>
+     * </ul>
      */
     private static final ParameterDescriptor<Double> ORIGIN_X;
 
@@ -67,6 +75,14 @@ public final class GeocentricToTopocentric extends 
AbstractProvider {
      * The operation parameter descriptor for the <cite>Geocentric Y of 
topocentric origin</cite> (Y) parameter value.
      *
      * <!-- Generated by ParameterNameTableGenerator -->
+     * <table class="sis">
+     *   <caption>Parameter names</caption>
+     *   <tr><td> EPSG:    </td><td> Geocentric Y of topocentric origin 
</td></tr>
+     * </table>
+     * <b>Notes:</b>
+     * <ul>
+     *   <li>No default value</li>
+     * </ul>
      */
     private static final ParameterDescriptor<Double> ORIGIN_Y;
 
@@ -74,6 +90,14 @@ public final class GeocentricToTopocentric extends 
AbstractProvider {
      * The operation parameter descriptor for the <cite>Geocentric Z of 
topocentric origin</cite> (Z) parameter value.
      *
      * <!-- Generated by ParameterNameTableGenerator -->
+     * <table class="sis">
+     *   <caption>Parameter names</caption>
+     *   <tr><td> EPSG:    </td><td> Geocentric Z of topocentric origin 
</td></tr>
+     * </table>
+     * <b>Notes:</b>
+     * <ul>
+     *   <li>No default value</li>
+     * </ul>
      */
     private static final ParameterDescriptor<Double> ORIGIN_Z;
 
diff --git 
a/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/provider/GeographicToTopocentric.java
 
b/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/provider/GeographicToTopocentric.java
index ab511aaaa6..368cd18795 100644
--- 
a/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/provider/GeographicToTopocentric.java
+++ 
b/core/sis-referencing/src/main/java/org/apache/sis/internal/referencing/provider/GeographicToTopocentric.java
@@ -51,6 +51,14 @@ public final class GeographicToTopocentric extends 
AbstractProvider {
      * The operation parameter descriptor for the <cite>Longitude of 
topocentric origin</cite> parameter value.
      *
      * <!-- Generated by ParameterNameTableGenerator -->
+     * <table class="sis">
+     *   <caption>Parameter names</caption>
+     *   <tr><td> EPSG:    </td><td> Longitude of topocentric origin </td></tr>
+     * </table>
+     * <b>Notes:</b>
+     * <ul>
+     *   <li>Value domain: [-180.0 … 180.0]°</li>
+     * </ul>
      */
     static final ParameterDescriptor<Double> ORIGIN_X;
 
@@ -58,6 +66,14 @@ public final class GeographicToTopocentric extends 
AbstractProvider {
      * The operation parameter descriptor for the <cite>Latitude of 
topocentric origin</cite> parameter value.
      *
      * <!-- Generated by ParameterNameTableGenerator -->
+     * <table class="sis">
+     *   <caption>Parameter names</caption>
+     *   <tr><td> EPSG:    </td><td> Latitude of topocentric origin </td></tr>
+     * </table>
+     * <b>Notes:</b>
+     * <ul>
+     *   <li>Value domain: [-90.0 … 90.0]°</li>
+     * </ul>
      */
     static final ParameterDescriptor<Double> ORIGIN_Y;
 
@@ -65,6 +81,10 @@ public final class GeographicToTopocentric extends 
AbstractProvider {
      * The operation parameter descriptor for the <cite>Ellipsoidal height of 
topocentric origin</cite> parameter value.
      *
      * <!-- Generated by ParameterNameTableGenerator -->
+     * <table class="sis">
+     *   <caption>Parameter names</caption>
+     *   <tr><td> EPSG:    </td><td> Ellipsoidal height of topocentric origin 
</td></tr>
+     * </table>
      */
     static final ParameterDescriptor<Double> ORIGIN_Z;
 
diff --git 
a/core/sis-referencing/src/test/java/org/apache/sis/test/integration/ConsistencyTest.java
 
b/core/sis-referencing/src/test/java/org/apache/sis/test/integration/ConsistencyTest.java
index 10470181af..437ca32336 100644
--- 
a/core/sis-referencing/src/test/java/org/apache/sis/test/integration/ConsistencyTest.java
+++ 
b/core/sis-referencing/src/test/java/org/apache/sis/test/integration/ConsistencyTest.java
@@ -74,8 +74,7 @@ public final strictfp class ConsistencyTest extends TestCase {
      */
     private static final Set<String> EXCLUDES = new HashSet<>(Arrays.asList(
         "CRS:1",            // Computer display: WKT parser alters the (i,j) 
axis names.
-        "EPSG:5819",        // EPSG topocentric example A: error while parsing 
WKT.
-        "EPSG:5820",        // EPSG topocentric example B: error while parsing 
WKT.
+        "EPSG:5819",        // EPSG topocentric example A: DerivedCRS wrongly 
handled as a ProjectedCRS. See SIS-518.
         "AUTO2:42001",      // This projection requires parameters, but we 
provide none.
         "AUTO2:42002",      // This projection requires parameters, but we 
provide none.
         "AUTO2:42003",      // This projection requires parameters, but we 
provide none.

Reply via email to