(minor: toLowerCase() should always be in the Locale.English locale)
Project: http://git-wip-us.apache.org/repos/asf/incubator-slider/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-slider/commit/b19e1571 Tree: http://git-wip-us.apache.org/repos/asf/incubator-slider/tree/b19e1571 Diff: http://git-wip-us.apache.org/repos/asf/incubator-slider/diff/b19e1571 Branch: refs/heads/develop Commit: b19e157178685b50d114611922999837d85cad59 Parents: ea5e690 Author: Steve Loughran <ste...@apache.org> Authored: Fri Oct 24 19:16:48 2014 +0100 Committer: Steve Loughran <ste...@apache.org> Committed: Fri Oct 24 21:51:10 2014 +0100 ---------------------------------------------------------------------- .../src/main/java/org/apache/slider/client/SliderClient.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/b19e1571/slider-core/src/main/java/org/apache/slider/client/SliderClient.java ---------------------------------------------------------------------- diff --git a/slider-core/src/main/java/org/apache/slider/client/SliderClient.java b/slider-core/src/main/java/org/apache/slider/client/SliderClient.java index f837ca4..4ac4031 100644 --- a/slider-core/src/main/java/org/apache/slider/client/SliderClient.java +++ b/slider-core/src/main/java/org/apache/slider/client/SliderClient.java @@ -646,7 +646,7 @@ public class SliderClient extends AbstractSliderLaunchedService implements RunSe CredentialProviderFactory.getProviders(c).get(0); Set<String> existingAliases = new HashSet<String>(credentialProvider.getAliases()); for (String alias : aliases) { - if (existingAliases.contains(alias.toLowerCase())) { + if (existingAliases.contains(alias.toLowerCase(Locale.ENGLISH))) { log.warn("Skipping creation of credentials for {}, " + "alias already exists in {}", alias, provider); continue;
