nscendoni commented on code in PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-auth-oauth-client/pull/13#discussion_r2007529223
##########
src/test/java/org/apache/sling/auth/oauth_client/OAuthUrisTest.java:
##########
@@ -44,17 +44,4 @@ void testRedirectUri() {
.hasQuery("c=mock-oidc&redirect=/foo");
}
- @Test
- void testRedirectUri_customPort_noRedirect() {
- context.request().setServerPort(8080);
- URI redirectUri =
OAuthUris.getOAuthEntryPointUri(MockOidcConnection.DEFAULT_CONNECTION,
context.request(), null);
Review Comment:
It can happens. Should `OAuthUris.getOAuthEntryPointUri()` return an
exception in that case?
And in that case shall we propagate that exception in
`OAuthEnabledSlingServlet` so that a 500 error with proper description is
returned to the browser?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
