rombert commented on code in PR #14:
URL:
https://github.com/apache/sling-org-apache-sling-auth-oauth-client/pull/14#discussion_r2024440145
##########
pom.xml:
##########
@@ -221,12 +229,16 @@
<repositoryUrl>file://${project.build.directory}/artifacts</repositoryUrl>
</repositoryUrls>
<launcherArguments>
+ <vm-options>
Review Comment:
Please make this part of a profile if needed otherwise we may get into port
clashes, especially on Jenkins.
##########
pom.xml:
##########
@@ -48,7 +48,15 @@
<build>
<plugins>
- <plugin>
+ <plugin>
Review Comment:
What is this supposed to achieve? If you want to export the package just
give it a `@Version` annotation, the rest is handled by the configuration
inherited from the parent pom.
##########
pom.xml:
##########
@@ -397,5 +409,47 @@
<version>1.40.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.sling</groupId>
+ <artifactId>org.apache.sling.jcr.api</artifactId>
+ <version>2.4.0</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.jackrabbit</groupId>
+ <artifactId>oak-auth-external</artifactId>
+ <version>1.40.0</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.osgi</groupId>
+ <artifactId>org.osgi.framework</artifactId>
+ <scope>provided</scope>
+ <version>1.10.0</version>
+ </dependency>
+ <dependency>
Review Comment:
We should not use the old Felix SCR annotations.
##########
src/main/features/main.json:
##########
@@ -16,6 +16,9 @@
"id":"com.nimbusds:lang-tag:1.7",
"start-order": 24
},
+ {
+ "id": "com.nimbusds:nimbus-jose-jwt:10.0.2"
Review Comment:
Please add a start-order, for consistency.
##########
pom.xml:
##########
@@ -221,12 +229,16 @@
<repositoryUrl>file://${project.build.directory}/artifacts</repositoryUrl>
</repositoryUrls>
<launcherArguments>
+ <vm-options>
+
<value>-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:3007</value>
+ </vm-options>
<frameworkProperties>
<org.osgi.service.http.port>${http.port}</org.osgi.service.http.port>
</frameworkProperties>
</launcherArguments>
<environmentVariables>
<IT_ENCRYPTION_PASSWORD>random</IT_ENCRYPTION_PASSWORD>
+
<JAVA_OPS>-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:3007</JAVA_OPS>
Review Comment:
Please make this part of a profile if needed otherwise we may get into port
clashes, especially on Jenkins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
