rombert commented on code in PR #17: URL: https://github.com/apache/sling-org-apache-sling-auth-oauth-client/pull/17#discussion_r2099767014
########## src/main/java/org/apache/sling/auth/oauth_client/ClientConnection.java: ########## @@ -34,4 +35,10 @@ public interface ClientConnection { * @return the name of the connection */ @NotNull String name(); + String clientId(); Review Comment: SonarQube checks are not mandatory, only Jenkins is. I would prefer to keep the duplication and not expose this API to consumers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org