(sling-org-apache-sling-engine) branch master updated: SLING-13137 Improve logging when file logger creation fails (#73)

[joerghoh]

This is an automated email from the ASF dual-hosted git repository.

joerghoh pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/sling-org-apache-sling-engine.git


The following commit(s) were added to refs/heads/master by this push:
     new c2edfde  SLING-13137 Improve logging when file logger creation fails 
(#73)
c2edfde is described below

commit c2edfde28abec6ffae52a267f0826cf137164115
Author: aswindhanan <73028762+aswi...@users.noreply.github.com>
AuthorDate: Wed Mar 25 07:13:21 2026 -0500

    SLING-13137 Improve logging when file logger creation fails (#73)
    
    * Improve logging when file logger creation fails
    
    Co-authored-by: Jörg Hoh <joerg...@users.noreply.github.com>
---
 .../org/apache/sling/engine/impl/log/RequestLoggerService.java    | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git 
a/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerService.java 
b/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerService.java
index 2f77fc0..c5c3f0c 100644
--- a/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerService.java
+++ b/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerService.java
@@ -33,6 +33,8 @@ import 
org.osgi.service.metatype.annotations.AttributeDefinition;
 import org.osgi.service.metatype.annotations.Designate;
 import org.osgi.service.metatype.annotations.ObjectClassDefinition;
 import org.osgi.service.metatype.annotations.Option;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * The <code>RequestLoggerService</code> is a factory component which gets
@@ -44,6 +46,8 @@ import org.osgi.service.metatype.annotations.Option;
 @Designate(ocd = RequestLoggerService.Config.class, factory = true)
 public class RequestLoggerService {
 
+    private static final Logger LOGGER = 
LoggerFactory.getLogger(RequestLoggerService.class);
+
     @ObjectClassDefinition(
             name = "Apache Sling Customizable Request Data Logger",
             description = "This configuration creates customizable "
@@ -158,9 +162,9 @@ public class RequestLoggerService {
         switch (outputType) {
             case OUTPUT_TYPE_FILE:
                 // file logging
+                File file = new File(output);
                 try {
                     // ensure the path is absolute
-                    File file = new File(output);
                     if (!file.isAbsolute()) {
                         final String home = 
bundleContext.getProperty("sling.home");
                         if (home != null) {
@@ -171,7 +175,7 @@ public class RequestLoggerService {
 
                     return new FileRequestLog(file);
                 } catch (IOException ioe) {
-                    // TODO: log
+                    LOGGER.error("Failed to create request log file at '{}'", 
file.getAbsolutePath(), ioe);
                 }
                 break;