royteeuwen commented on PR #58: URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/58#issuecomment-5558901061
Not late at all — done. Split into a two-PR stack: - **#58** (this one, base `master`) — the SLING-13321 feature: threading the `[RESULT]` email onto the `[VOTE]` email, plus identifying the vote email by subject instead of by position. - **#59** (stacked on this) — the vote-counting bugfix: not counting an earlier run's `[RESULT]` email as a vote. No code changed in the split — the two commits were already separate, so each PR is exactly the commit that was already here, and both build and pass on their own. The bugfix is genuinely independent of the feature; it is only stacked rather than parallel because both touch the same tally expression and would otherwise conflict. If you would rather it land first and independently, I can flip the stack order — it needs a small rework of both diffs, but nothing structural. Likewise happy to file it under its own Jira issue if you would prefer that over sharing SLING-13321. One thing I would value your opinion on while you are in here, called out in the description above: we kept the `[RESULT]` subject prefix per ASF convention, so the threading is done purely with `In-Reply-To`/`References`. That is correct for the archive and for threading clients, but Gmail also weighs subject similarity and may still split it into its own conversation. If your goal was one conversation in your mail client, a plain `Re: [VOTE] Release …` subject would be more reliable — at the cost of a prefix the project has used for years. Your call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
