This is an automated email from the ASF dual-hosted git repository.
radu pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/sling-org-apache-sling-scripting-sightly-testing.git
The following commit(s) were added to refs/heads/master by this push:
new d41ff5a SLING-7755 - JavaUseProvider might attempt to instantiate
interfaces or abstract classes
d41ff5a is described below
commit d41ff5aca3972812e413ba339ebb4abc0bac09ab
Author: Radu Cotescu <[email protected]>
AuthorDate: Mon Aug 27 18:22:34 2018 +0200
SLING-7755 - JavaUseProvider might attempt to instantiate interfaces or
abstract classes
* applied slightly modified patch provided by Santiago Garcia Pimentel
<[email protected]>
---
pom.xml | 14 +++++++-------
.../scripting/sightly/it/SlingSpecificsSightlyIT.java | 16 ++++++++++++++++
2 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/pom.xml b/pom.xml
index 448a7dd..62701de 100644
--- a/pom.xml
+++ b/pom.xml
@@ -76,12 +76,12 @@
<jacoco.maven.plugin.version>0.7.9</jacoco.maven.plugin.version>
<!-- HTL modules under test versions -->
-
<org.apache.sling.scripting.sightly.compiler.version>1.0.25-1.4.0-SNAPSHOT</org.apache.sling.scripting.sightly.compiler.version>
-
<org.apache.sling.scripting.sightly.compiler.java.version>1.0.23-1.4.0-SNAPSHOT</org.apache.sling.scripting.sightly.compiler.java.version>
+
<org.apache.sling.scripting.sightly.compiler.version>1.0.23-1.4.0-SNAPSHOT</org.apache.sling.scripting.sightly.compiler.version>
+
<org.apache.sling.scripting.sightly.compiler.java.version>1.0.27-1.4.0-SNAPSHOT</org.apache.sling.scripting.sightly.compiler.java.version>
<org.apache.sling.scripting.sightly.version>1.0.55-1.4.0-SNAPSHOT</org.apache.sling.scripting.sightly.version>
<org.apache.sling.scripting.sightly.js.provider.version>1.0.27-SNAPSHOT</org.apache.sling.scripting.sightly.js.provider.version>
<org.apache.sling.scripting.sightly.models.provider.version>1.0.7-SNAPSHOT</org.apache.sling.scripting.sightly.models.provider.version>
-
<org.apache.sling.scripting.sightly.testing.content.version>1.0.9-1.4.0-SNAPSHOT</org.apache.sling.scripting.sightly.testing.content.version>
+
<org.apache.sling.scripting.sightly.testing.content.version>1.0.11-1.4.0-SNAPSHOT</org.apache.sling.scripting.sightly.testing.content.version>
</properties>
<build>
@@ -250,12 +250,12 @@
<activeByDefault>false</activeByDefault>
</activation>
<properties>
-
<org.apache.sling.scripting.sightly.compiler.version>1.0.20-1.3.1</org.apache.sling.scripting.sightly.compiler.version>
-
<org.apache.sling.scripting.sightly.compiler.java.version>1.0.22-1.3.1</org.apache.sling.scripting.sightly.compiler.java.version>
-
<org.apache.sling.scripting.sightly.version>1.0.48-1.3.1</org.apache.sling.scripting.sightly.version>
+
<org.apache.sling.scripting.sightly.compiler.version>1.0.22-1.4.0</org.apache.sling.scripting.sightly.compiler.version>
+
<org.apache.sling.scripting.sightly.compiler.java.version>1.0.26-1.4.0</org.apache.sling.scripting.sightly.compiler.java.version>
+
<org.apache.sling.scripting.sightly.version>1.0.54-1.4.0</org.apache.sling.scripting.sightly.version>
<org.apache.sling.scripting.sightly.js.provider.version>1.0.26</org.apache.sling.scripting.sightly.js.provider.version>
<org.apache.sling.scripting.sightly.models.provider.version>1.0.6</org.apache.sling.scripting.sightly.models.provider.version>
-
<org.apache.sling.scripting.sightly.testing.content.version>1.0.8-1.3.1</org.apache.sling.scripting.sightly.testing.content.version>
+
<org.apache.sling.scripting.sightly.testing.content.version>1.0.10-1.4.0</org.apache.sling.scripting.sightly.testing.content.version>
</properties>
<build>
<plugins>
diff --git
a/src/test/java/org/apache/sling/scripting/sightly/it/SlingSpecificsSightlyIT.java
b/src/test/java/org/apache/sling/scripting/sightly/it/SlingSpecificsSightlyIT.java
index bdbc878..642b054 100644
---
a/src/test/java/org/apache/sling/scripting/sightly/it/SlingSpecificsSightlyIT.java
+++
b/src/test/java/org/apache/sling/scripting/sightly/it/SlingSpecificsSightlyIT.java
@@ -44,6 +44,8 @@ public class SlingSpecificsSightlyIT {
private static String launchpadURL;
private static final String SLING_USE = "/sightly/use.html";
private static final String SLING_JAVA_USE_NPE =
"/sightly/use.javaerror.html";
+ private static final String SLING_JAVA_USE_INTERFACE =
"/sightly/use.interface.html";
+ private static final String SLING_JAVA_USE_ABSTRACT =
"/sightly/use.abstractClass.html";
private static final String SLING_RESOURCE = "/sightly/resource.html";
private static final String SLING_RESOURCE_ACTUAL =
"/sightly/actualresource.html";
private static final String SLING_TEMPLATE = "/sightly/template.html";
@@ -116,6 +118,20 @@ public class SlingSpecificsSightlyIT {
}
@Test
+ public void testInterfaceUset() {
+ String url = launchpadURL + SLING_JAVA_USE_INTERFACE;
+ String pageContent = client.getStringContent(url, 500);
+ assertTrue(pageContent.contains("No use provider could resolve
identifier"));
+ }
+
+ @Test
+ public void testAbstractClassUse() {
+ String url = launchpadURL + SLING_JAVA_USE_ABSTRACT;
+ String pageContent = client.getStringContent(url, 500);
+ assertTrue(pageContent.contains("No use provider could resolve
identifier"));
+ }
+
+ @Test
public void testDataSlyResourceArraySelectors() {
String url = launchpadURL + SLING_RESOURCE;
String pageContent = client.getStringContent(url, 200);
