[sling-org-apache-sling-distribution-journal] branch master updated: SLING-9464 - Increase test coverage

[cschneider]

This is an automated email from the ASF dual-hosted git repository.

cschneider pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/sling-org-apache-sling-distribution-journal.git


The following commit(s) were added to refs/heads/master by this push:
     new e8cf9b1  SLING-9464 - Increase test coverage
e8cf9b1 is described below

commit e8cf9b1149a56f5ed83beed37a5fdc6059d7fed2
Author: Christian Schneider <cschn...@adobe.com>
AuthorDate: Mon May 25 15:44:29 2020 +0200

    SLING-9464 - Increase test coverage
---
 .../shared/PublisherConfigurationAvailable.java    |  2 +-
 .../PublisherConfigurationAvailableTest.java       | 22 +++++++++++++++++++---
 2 files changed, 20 insertions(+), 4 deletions(-)

diff --git 
a/src/main/java/org/apache/sling/distribution/journal/impl/shared/PublisherConfigurationAvailable.java
 
b/src/main/java/org/apache/sling/distribution/journal/impl/shared/PublisherConfigurationAvailable.java
index 5def842..fdfcc43 100644
--- 
a/src/main/java/org/apache/sling/distribution/journal/impl/shared/PublisherConfigurationAvailable.java
+++ 
b/src/main/java/org/apache/sling/distribution/journal/impl/shared/PublisherConfigurationAvailable.java
@@ -80,7 +80,7 @@ public class PublisherConfigurationAvailable implements 
ManagedServiceFactory {
 
     @Override
     public String getName() {
-        return "DistributionPublisher marker";
+        return this.getClass().getSimpleName();
     }
 
     @Override
diff --git 
a/src/test/java/org/apache/sling/distribution/journal/impl/shared/PublisherConfigurationAvailableTest.java
 
b/src/test/java/org/apache/sling/distribution/journal/impl/shared/PublisherConfigurationAvailableTest.java
index b8ee5ce..c137d83 100644
--- 
a/src/test/java/org/apache/sling/distribution/journal/impl/shared/PublisherConfigurationAvailableTest.java
+++ 
b/src/test/java/org/apache/sling/distribution/journal/impl/shared/PublisherConfigurationAvailableTest.java
@@ -20,11 +20,12 @@ package org.apache.sling.distribution.journal.impl.shared;
 
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.junit.Assert.assertThat;
+import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
-import java.util.Dictionary;
 import java.util.Hashtable;
 
+import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -51,10 +52,15 @@ public class PublisherConfigurationAvailableTest {
         configAvailable = new PublisherConfigurationAvailable();
         configAvailable.activate(context);
     }
+    
+    @After
+    public void after() {
+    }
 
     @Test
     public void testNoConfig() {
         assertThat(configAvailable.isAvailable(), equalTo(false));
+        configAvailable.deactivate();
     }
     
     @Test
@@ -62,12 +68,22 @@ public class PublisherConfigurationAvailableTest {
         
when(context.registerService(Mockito.eq(PublisherConfigurationAvailable.class), 
Mockito.eq(configAvailable), Mockito.anyObject()))
             .thenReturn(reg);
         
-        Dictionary<String, ?> properties = new Hashtable<>();
-        configAvailable.updated("any", properties);
+        configAvailable.updated("any", new Hashtable<>());
+        assertThat(configAvailable.isAvailable(), equalTo(true));
+        
+        configAvailable.updated("any", new Hashtable<>());
         assertThat(configAvailable.isAvailable(), equalTo(true));
         
         configAvailable.deleted("any");
         assertThat(configAvailable.isAvailable(), equalTo(true));
+        
+        configAvailable.deactivate();
+        verify(reg).unregister();
+    }
+    
+    @Test
+    public void testGetName() throws ConfigurationException {
+        assertThat(configAvailable.getName(), 
equalTo(PublisherConfigurationAvailable.class.getSimpleName()));
     }
 
 }