[solr] branch main updated: SOLR-16584: BATS test fails stopping two instances (#1240)

[krisden]

This is an automated email from the ASF dual-hosted git repository.

krisden pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/solr.git


The following commit(s) were added to refs/heads/main by this push:
     new f8c78cf499e SOLR-16584: BATS test fails stopping two instances (#1240)
f8c78cf499e is described below

commit f8c78cf499e30f8f201fb5252d87568953f4a164
Author: Kevin Risden <risd...@users.noreply.github.com>
AuthorDate: Thu Dec 15 18:15:29 2022 -0500

    SOLR-16584: BATS test fails stopping two instances (#1240)
    
    * Assert that Solr has started before shutting back down again
    * capture logs on test failure
    
    Co-authored-by: Jan Høydahl <jan...@users.noreply.github.com>
---
 .github/workflows/bin-solr-test.yml                                | 7 +++++++
 .../test/{test_start_solr.bats_disabled => test_start_solr.bats}   | 2 ++
 2 files changed, 9 insertions(+)

diff --git a/.github/workflows/bin-solr-test.yml 
b/.github/workflows/bin-solr-test.yml
index 92cc2d2dc9f..6daadd1817e 100644
--- a/.github/workflows/bin-solr-test.yml
+++ b/.github/workflows/bin-solr-test.yml
@@ -38,3 +38,10 @@ jobs:
       run: ./gradlew localSettings
     - name: Test the bin/solr script
       run: ./gradlew integrationTests
+    - name: Archive logs
+      if: ${{ failure() }}
+      uses: actions/upload-artifact@v3
+      with:
+        name: logs
+        path: solr/packaging/build/test-output
+
diff --git a/solr/packaging/test/test_start_solr.bats_disabled 
b/solr/packaging/test/test_start_solr.bats
similarity index 89%
rename from solr/packaging/test/test_start_solr.bats_disabled
rename to solr/packaging/test/test_start_solr.bats
index 68469063ff3..522324aabab 100644
--- a/solr/packaging/test/test_start_solr.bats_disabled
+++ b/solr/packaging/test/test_start_solr.bats
@@ -31,6 +31,8 @@ teardown() {
 @test "SOLR11740 check f" {
   solr start
   solr start -p 7574
+  solr assert --started http://localhost:8983/solr --timeout 5000
+  solr assert --started http://localhost:7574/solr --timeout 5000
   run bash -c 'solr stop -all 2>&1'
   refute_output --partial 'forcefully killing'
 }