This is an automated email from the ASF dual-hosted git repository. epugh pushed a commit to branch branch_9x in repository https://gitbox.apache.org/repos/asf/solr.git
The following commit(s) were added to refs/heads/branch_9x by this push: new 642216ccaab Reformat comment better (#2910) 642216ccaab is described below commit 642216ccaab3270643f86a4b9834f300b474ec97 Author: Eric Pugh <ep...@opensourceconnections.com> AuthorDate: Tue Dec 17 09:55:19 2024 -0500 Reformat comment better (#2910) (cherry picked from commit 9d126d4c69e68519da795ccc184bc5b3d8625833) --- .../src/java/org/apache/solr/handler/ReplicationHandler.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java b/solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java index 034130754a0..4d7e4a34f22 100644 --- a/solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java +++ b/solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java @@ -1571,10 +1571,11 @@ public class ReplicationHandler extends RequestHandlerBase public static final String FETCH_FROM_LEADER = "fetchFromLeader"; - // in case of TLOG replica, if leaderVersion = zero, don't do commit - // otherwise updates from current tlog won't be copied over properly to the new tlog, leading to - // data - // loss + // In case of TLOG replica, if leaderVersion = zero, don't do commit + // otherwise updates from current tlog won't be copied over properly to the new tlog, + // leading to data loss. + // Don't commit on leader version zero for PULL replicas as PULL should only get its index + // state from leader. public static final String SKIP_COMMIT_ON_LEADER_VERSION_ZERO = "skipCommitOnLeaderVersionZero"; /**