This is an automated email from the ASF dual-hosted git repository. psalagnac pushed a commit to branch bad-method in repository https://gitbox.apache.org/repos/asf/solr.git
commit 5f256ec7aec2d8ecc245620f684b499c42fa74ad Author: Pierre Salagnac <[email protected]> AuthorDate: Thu Jan 23 22:31:45 2025 +0100 Remove broken and unused ZkStateReader.getReplicaProps() --- .../apache/solr/common/cloud/ZkStateReader.java | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java b/solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java index f450c11668d..4f11b43a150 100644 --- a/solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java +++ b/solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java @@ -1002,30 +1002,12 @@ public class ZkStateReader implements SolrCloseable { public List<ZkCoreNodeProps> getReplicaProps( String collection, String shardId, String thisCoreNodeName) { - return getReplicaProps(collection, shardId, thisCoreNodeName, null); - } - - public List<ZkCoreNodeProps> getReplicaProps( - String collection, - String shardId, - String thisCoreNodeName, - Replica.State mustMatchStateFilter) { - return getReplicaProps(collection, shardId, thisCoreNodeName, mustMatchStateFilter, null); - } - - public List<ZkCoreNodeProps> getReplicaProps( - String collection, - String shardId, - String thisCoreNodeName, - Replica.State mustMatchStateFilter, - Replica.State mustNotMatchStateFilter) { - // TODO: We don't need all these getReplicaProps method overloading. Also, it's odd that the - // default is to return replicas of type TLOG and NRT only + // TODO: It's odd that the default is to return replicas of type TLOG and NRT only return getReplicaProps( collection, shardId, thisCoreNodeName, - mustMatchStateFilter, + null, null, EnumSet.of(Replica.Type.TLOG, Replica.Type.NRT)); }
