(solr) branch main updated: Flip solr.hideStackTrace to solr.responses.stacktrace.enabled equivalent. (#3503)

[epugh]

This is an automated email from the ASF dual-hosted git repository.

epugh pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/solr.git


The following commit(s) were added to refs/heads/main by this push:
     new dea67fd777d Flip solr.hideStackTrace to 
solr.responses.stacktrace.enabled equivalent. (#3503)
dea67fd777d is described below

commit dea67fd777d304d2b1f9634e5353bfeeee15f8a6
Author: Eric Pugh <ep...@opensourceconnections.com>
AuthorDate: Sun Aug 24 10:02:55 2025 -0400

    Flip solr.hideStackTrace to solr.responses.stacktrace.enabled equivalent. 
(#3503)
    
    Tricky one because I didn't want to change the solr.xml name AS well, so 
now in solr.xml we have solr.hideStackTrace, but system property equivalent is 
solr.responses.stacktrace.enabled.
---
 solr/core/src/java/org/apache/solr/core/NodeConfig.java             | 3 ++-
 solr/solrj/src/java/org/apache/solr/common/util/EnvUtils.java       | 6 ++++++
 .../solrj/src/resources/DeprecatedSystemPropertyMappings.properties | 1 +
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/solr/core/src/java/org/apache/solr/core/NodeConfig.java 
b/solr/core/src/java/org/apache/solr/core/NodeConfig.java
index 91c14eb72ad..290c17835b4 100644
--- a/solr/core/src/java/org/apache/solr/core/NodeConfig.java
+++ b/solr/core/src/java/org/apache/solr/core/NodeConfig.java
@@ -618,7 +618,8 @@ public class NodeConfig {
     private String defaultZkHost;
     private Set<Path> allowPaths = Collections.emptySet();
     private List<String> allowUrls = Collections.emptyList();
-    private boolean hideStackTrace = Boolean.getBoolean("solr.hideStackTrace");
+    private boolean hideStackTrace =
+        
!(Boolean.parseBoolean(System.getProperty("solr.responses.stacktrace.enabled", 
"true")));
 
     private final Path solrHome;
     private final String nodeName;
diff --git a/solr/solrj/src/java/org/apache/solr/common/util/EnvUtils.java 
b/solr/solrj/src/java/org/apache/solr/common/util/EnvUtils.java
index 22b5a2ec8ea..6f613016cf8 100644
--- a/solr/solrj/src/java/org/apache/solr/common/util/EnvUtils.java
+++ b/solr/solrj/src/java/org/apache/solr/common/util/EnvUtils.java
@@ -232,6 +232,12 @@ public class EnvUtils {
               deprecatedKey,
               key);
           setProperty(key, String.valueOf(!Boolean.getBoolean(deprecatedKey)));
+        } else if (deprecatedKey.equals("solr.hide.stack.trace")) {
+          log.warn(
+              "Converting from legacy system property {} to modern .enabled 
equivalent {} by flipping the boolean property value.",
+              deprecatedKey,
+              key);
+          setProperty(key, String.valueOf(!Boolean.getBoolean(deprecatedKey)));
         } else {
           setProperty(key, sysProperties.getProperty(deprecatedKey));
         }
diff --git 
a/solr/solrj/src/resources/DeprecatedSystemPropertyMappings.properties 
b/solr/solrj/src/resources/DeprecatedSystemPropertyMappings.properties
index 88c0210edcc..da2227a7b72 100644
--- a/solr/solrj/src/resources/DeprecatedSystemPropertyMappings.properties
+++ b/solr/solrj/src/resources/DeprecatedSystemPropertyMappings.properties
@@ -19,3 +19,4 @@ 
solr.enable.remote.streaming=solr.requests.streaming.remote.enabled
 solr.enable.stream.body=solr.requests.streaming.body.enabled
 solr.delete.unknown.cores=solr.cloud.startup.delete.unknown.cores.enabled
 solr.config.set.forbidden.file.types=solr.configset.forbidden.file.types
+solr.hide.stack.trace=solr.responses.stacktrace.enabled