(solr) branch main updated: Fix confusing assertion messages

[psalagnac]

This is an automated email from the ASF dual-hosted git repository.

psalagnac pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/solr.git


The following commit(s) were added to refs/heads/main by this push:
     new c3a670a72bb Fix confusing assertion messages
c3a670a72bb is described below

commit c3a670a72bbabc7fa92c0250c886b3e20c88ec9a
Author: Pierre Salagnac <psalag...@apache.org>
AuthorDate: Thu Sep 18 14:28:42 2025 +0200

    Fix confusing assertion messages
---
 solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java         | 4 ++--
 .../src/test/org/apache/solr/cloud/OverseerModifyCollectionTest.java  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java 
b/solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java
index de433340cc7..20f17609ffb 100644
--- a/solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/DeleteShardTest.java
@@ -116,8 +116,8 @@ public class DeleteShardTest extends SolrCloudTestCase {
     waitForState("Expected 'b' to be removed", collection, c -> 
c.getSlice("b") == null);
 
     assertEquals(1, getCollectionState(collection).getActiveSlices().size());
-    assertTrue("Instance directory still exists", 
FileUtils.fileExists(coreStatus.instanceDir));
-    assertTrue("Data directory still exists", 
FileUtils.fileExists(coreStatus.dataDir));
+    assertTrue("Instance directory not deleted", 
FileUtils.fileExists(coreStatus.instanceDir));
+    assertTrue("Data directory not deleted", 
FileUtils.fileExists(coreStatus.dataDir));
   }
 
   private void setSliceState(String collectionName, String shardId, 
Slice.State state)
diff --git 
a/solr/core/src/test/org/apache/solr/cloud/OverseerModifyCollectionTest.java 
b/solr/core/src/test/org/apache/solr/cloud/OverseerModifyCollectionTest.java
index e9cb4d775ba..bae0a0cafb2 100644
--- a/solr/core/src/test/org/apache/solr/cloud/OverseerModifyCollectionTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/OverseerModifyCollectionTest.java
@@ -46,7 +46,7 @@ public class OverseerModifyCollectionTest extends 
SolrCloudTestCase {
         CollectionAdminRequest.modifyCollection(
                 collName, Collections.singletonMap("collection.configName", 
"conf2"))
             .processAndWait(cluster.getSolrClient(), DEFAULT_TIMEOUT);
-    assertEquals(requestStatusState, RequestStatusState.COMPLETED);
+    assertEquals(RequestStatusState.COMPLETED, requestStatusState);
 
     String configName =
         
cluster.getSolrClient().getClusterStateProvider().getCollection(collName).getConfigName();