This is an automated email from the ASF dual-hosted git repository. dsmiley pushed a commit to branch branch_10x in repository https://gitbox.apache.org/repos/asf/solr.git
commit f650e7e3d7bfeef83716d30f7d97da0b0ec39f61 Author: Eric Pugh <[email protected]> AuthorDate: Tue Sep 8 09:28:27 2026 -0400 Review and tidy solr/modules/language-models code (#4836) (cherry picked from commit 2ffb3b97db10b6c9ed0a99698d6e47cebec5904b) --- .../languagemodels/update/processor/TextToVectorUpdateProcessor.java | 2 +- .../src/test/org/apache/solr/languagemodels/TestLanguageModelBase.java | 2 +- .../solr/languagemodels/store/rest/TestLargeLanguageModelManager.java | 2 +- .../solr/languagemodels/store/rest/TestTextToVectorModelManager.java | 2 +- .../factory/DocumentEnrichmentUpdateProcessorFactoryTest.java | 3 +-- 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/solr/modules/language-models/src/java/org/apache/solr/languagemodels/update/processor/TextToVectorUpdateProcessor.java b/solr/modules/language-models/src/java/org/apache/solr/languagemodels/update/processor/TextToVectorUpdateProcessor.java index 44c75988e7f..d775b70c47e 100644 --- a/solr/modules/language-models/src/java/org/apache/solr/languagemodels/update/processor/TextToVectorUpdateProcessor.java +++ b/solr/modules/language-models/src/java/org/apache/solr/languagemodels/update/processor/TextToVectorUpdateProcessor.java @@ -65,7 +65,7 @@ public class TextToVectorUpdateProcessor extends UpdateRequestProcessor { try { String textToVectorise = inputFieldContent.getValue().toString(); float[] vector = textToVector.vectorise(textToVectorise); - List<Float> vectorAsList = new ArrayList<Float>(vector.length); + List<Float> vectorAsList = new ArrayList<>(vector.length); for (float f : vector) { vectorAsList.add(f); } diff --git a/solr/modules/language-models/src/test/org/apache/solr/languagemodels/TestLanguageModelBase.java b/solr/modules/language-models/src/test/org/apache/solr/languagemodels/TestLanguageModelBase.java index 99d241fdde5..908754bd1c6 100644 --- a/solr/modules/language-models/src/test/org/apache/solr/languagemodels/TestLanguageModelBase.java +++ b/solr/modules/language-models/src/test/org/apache/solr/languagemodels/TestLanguageModelBase.java @@ -150,7 +150,7 @@ public class TestLanguageModelBase extends RestTestBase { assertJPut(LargeLanguageModelStore.REST_END_POINT, model, "/responseHeader/status==0"); } - protected static void prepareIndex() throws Exception { + protected static void prepareIndex() { List<SolrInputDocument> docsToIndex = prepareDocs(); for (SolrInputDocument doc : docsToIndex) { assertU(adoc(doc)); diff --git a/solr/modules/language-models/src/test/org/apache/solr/languagemodels/store/rest/TestLargeLanguageModelManager.java b/solr/modules/language-models/src/test/org/apache/solr/languagemodels/store/rest/TestLargeLanguageModelManager.java index bb785d90719..051b67a2124 100644 --- a/solr/modules/language-models/src/test/org/apache/solr/languagemodels/store/rest/TestLargeLanguageModelManager.java +++ b/solr/modules/language-models/src/test/org/apache/solr/languagemodels/store/rest/TestLargeLanguageModelManager.java @@ -58,7 +58,7 @@ public class TestLargeLanguageModelManager extends TestLanguageModelBase { final ManagedResource res = restManager.getManagedResource(resourceId); assertTrue(res instanceof LargeLanguageModelStore); - assertEquals(res.getResourceId(), resourceId); + assertEquals(resourceId, res.getResourceId()); } @Test diff --git a/solr/modules/language-models/src/test/org/apache/solr/languagemodels/store/rest/TestTextToVectorModelManager.java b/solr/modules/language-models/src/test/org/apache/solr/languagemodels/store/rest/TestTextToVectorModelManager.java index 0dba83a8d97..b63635a19ca 100644 --- a/solr/modules/language-models/src/test/org/apache/solr/languagemodels/store/rest/TestTextToVectorModelManager.java +++ b/solr/modules/language-models/src/test/org/apache/solr/languagemodels/store/rest/TestTextToVectorModelManager.java @@ -58,7 +58,7 @@ public class TestTextToVectorModelManager extends TestLanguageModelBase { final ManagedResource res = restManager.getManagedResource(resourceId); assertTrue(res instanceof TextToVectorModelStore); - assertEquals(res.getResourceId(), resourceId); + assertEquals(resourceId, res.getResourceId()); } @Test diff --git a/solr/modules/language-models/src/test/org/apache/solr/languagemodels/update/processor/factory/DocumentEnrichmentUpdateProcessorFactoryTest.java b/solr/modules/language-models/src/test/org/apache/solr/languagemodels/update/processor/factory/DocumentEnrichmentUpdateProcessorFactoryTest.java index 10c0137bd32..45f56803110 100644 --- a/solr/modules/language-models/src/test/org/apache/solr/languagemodels/update/processor/factory/DocumentEnrichmentUpdateProcessorFactoryTest.java +++ b/solr/modules/language-models/src/test/org/apache/solr/languagemodels/update/processor/factory/DocumentEnrichmentUpdateProcessorFactoryTest.java @@ -419,8 +419,7 @@ public class DocumentEnrichmentUpdateProcessorFactoryTest extends TestLanguageMo String outputFieldName, String prompt, SolrCore core, - String modelName) - throws Exception { + String modelName) { LargeLanguageModelStore.getManagedModelStore(core) .addModel(new SolrLargeLanguageModel(modelName, null, null));
