This is an automated email from the ASF dual-hosted git repository.
epugh pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/solr-mcp.git
The following commit(s) were added to refs/heads/main by this push:
new e118512d refactor(collection): reduce CollectionService internal
method visibility (#103)
e118512d is described below
commit e118512d5ef9f37401332b576e1515d5c056ce21
Author: Aditya Parikh <[email protected]>
AuthorDate: Wed Sep 16 10:46:35 2026 -0400
refactor(collection): reduce CollectionService internal method visibility
(#103)
Change buildIndexStats(), buildQueryStats(), getCacheMetrics(), and
getHandlerMetrics() from public to package-private. These are internal
implementation details not called outside the collection package.
Closes #17
Signed-off-by: Aditya Parikh <[email protected]>
Signed-off-by: adityamparikh <[email protected]>
Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>
---
.../org/apache/solr/mcp/server/collection/CollectionService.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
a/src/main/java/org/apache/solr/mcp/server/collection/CollectionService.java
b/src/main/java/org/apache/solr/mcp/server/collection/CollectionService.java
index 67860822..1a572003 100644
--- a/src/main/java/org/apache/solr/mcp/server/collection/CollectionService.java
+++ b/src/main/java/org/apache/solr/mcp/server/collection/CollectionService.java
@@ -578,7 +578,7 @@ public class CollectionService {
* @see IndexStats
* @see LukeResponse
*/
- public IndexStats buildIndexStats(LukeResponse lukeResponse) {
+ IndexStats buildIndexStats(LukeResponse lukeResponse) {
NamedList<Object> indexInfo = lukeResponse.getIndexInfo();
// Extract index information using helper methods
@@ -619,7 +619,7 @@ public class CollectionService {
* @see QueryStats
* @see QueryResponse
*/
- public QueryStats buildQueryStats(QueryResponse response) {
+ QueryStats buildQueryStats(QueryResponse response) {
return new QueryStats(response.getQTime(),
response.getResults().getNumFound(),
response.getResults().getStart(),
response.getResults().getMaxScore());
@@ -674,7 +674,7 @@ public class CollectionService {
* @see #extractCacheStats(NamedList)
* @see #isCacheStatsEmpty(CacheStats)
*/
- public @Nullable CacheStats getCacheMetrics(String collection) throws
SolrServerException, IOException {
+ @Nullable CacheStats getCacheMetrics(String collection) throws
SolrServerException, IOException {
String actualCollection = extractCollectionName(collection);
if (!validateCollectionExists(actualCollection)) {
@@ -791,7 +791,7 @@ public class CollectionService {
* @see #fetchFlatHandlerInfo(String, String, String)
* @see #isHandlerStatsEmpty(HandlerStats)
*/
- public @Nullable HandlerStats getHandlerMetrics(String collection)
throws SolrServerException, IOException {
+ @Nullable HandlerStats getHandlerMetrics(String collection) throws
SolrServerException, IOException {
String actualCollection = extractCollectionName(collection);
if (!validateCollectionExists(actualCollection)) {
