Repository: spark Updated Branches: refs/heads/master ba19689fe -> 3be2a887b
[SPARK-4984][CORE][WEBUI] Adding a pop-up containing the full job description when it is very long In some case the job description will be very long, such as a long sql. refer to #3718 This PR add a pop-up for job description when it is long.   Author: wangfei <wangf...@huawei.com> Closes #3819 from scwf/popup-descrip-ui and squashes the following commits: ba02b83 [wangfei] address comments a7c5e7b [wangfei] spot that it's been truncated fbf6162 [wangfei] Merge branch 'master' into popup-descrip-ui 0bca96d [wangfei] remove no use val 4b55c3b [wangfei] fix style issue 353c6f4 [wangfei] pop up the description of job with a styled read-only text form field Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/3be2a887 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/3be2a887 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/3be2a887 Branch: refs/heads/master Commit: 3be2a887bf6107b6398e472872b22175ea4ae1f7 Parents: ba19689 Author: wangfei <wangf...@huawei.com> Authored: Wed Jan 21 15:27:42 2015 -0800 Committer: Josh Rosen <joshro...@databricks.com> Committed: Wed Jan 21 15:27:42 2015 -0800 ---------------------------------------------------------------------- core/src/main/resources/org/apache/spark/ui/static/webui.css | 8 ++++++++ .../main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala | 2 +- .../src/main/scala/org/apache/spark/ui/jobs/StageTable.scala | 3 +-- 3 files changed, 10 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/3be2a887/core/src/main/resources/org/apache/spark/ui/static/webui.css ---------------------------------------------------------------------- diff --git a/core/src/main/resources/org/apache/spark/ui/static/webui.css b/core/src/main/resources/org/apache/spark/ui/static/webui.css index f02b035..a1f7133 100644 --- a/core/src/main/resources/org/apache/spark/ui/static/webui.css +++ b/core/src/main/resources/org/apache/spark/ui/static/webui.css @@ -121,6 +121,14 @@ pre { border: none; } +.description-input { + overflow: hidden; + text-overflow: ellipsis; + width: 100%; + white-space: nowrap; + display: block; +} + .stacktrace-details { max-height: 300px; overflow-y: auto; http://git-wip-us.apache.org/repos/asf/spark/blob/3be2a887/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala b/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala index 8121270..045c69d 100644 --- a/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala +++ b/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala @@ -64,7 +64,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends WebUIPage("") { {job.jobId} {job.jobGroup.map(id => s"($id)").getOrElse("")} </td> <td> - <div><em>{lastStageDescription}</em></div> + <span class="description-input" title={lastStageDescription}>{lastStageDescription}</span> <a href={detailUrl}>{lastStageName}</a> </td> <td sorttable_customkey={job.submissionTime.getOrElse(-1).toString}> http://git-wip-us.apache.org/repos/asf/spark/blob/3be2a887/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala b/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala index e7d6244..703d43f 100644 --- a/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala +++ b/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala @@ -112,9 +112,8 @@ private[ui] class StageTableBase( stageData <- listener.stageIdToData.get((s.stageId, s.attemptId)) desc <- stageData.description } yield { - <div><em>{desc}</em></div> + <span class="description-input" title={desc}>{desc}</span> } - <div>{stageDesc.getOrElse("")} {killLink} {nameLink} {details}</div> } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
