Repository: spark Updated Branches: refs/heads/master f7fe9e474 -> 084fef76e
[SPARK-7976] Add style checker to disallow overriding finalize. Author: Reynold Xin <r...@databricks.com> Closes #6528 from rxin/style-finalizer and squashes the following commits: a2211ca [Reynold Xin] [SPARK-7976] Enable NoFinalizeChecker. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/084fef76 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/084fef76 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/084fef76 Branch: refs/heads/master Commit: 084fef76e90116c6465cd6fad7c0197c3e4d4313 Parents: f7fe9e4 Author: Reynold Xin <r...@databricks.com> Authored: Sat May 30 23:36:32 2015 -0700 Committer: Reynold Xin <r...@databricks.com> Committed: Sat May 30 23:36:32 2015 -0700 ---------------------------------------------------------------------- core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala | 2 ++ scalastyle-config.xml | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/084fef76/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala b/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala index a77bf42..51388f0 100644 --- a/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala +++ b/core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala @@ -843,6 +843,7 @@ private class PythonAccumulatorParam(@transient serverHost: String, serverPort: * An Wrapper for Python Broadcast, which is written into disk by Python. It also will * write the data into disk after deserialization, then Python can read it from disks. */ +// scalastyle:off no.finalize private[spark] class PythonBroadcast(@transient var path: String) extends Serializable { /** @@ -884,3 +885,4 @@ private[spark] class PythonBroadcast(@transient var path: String) extends Serial } } } +// scalastyle:on no.finalize http://git-wip-us.apache.org/repos/asf/spark/blob/084fef76/scalastyle-config.xml ---------------------------------------------------------------------- diff --git a/scalastyle-config.xml b/scalastyle-config.xml index a009816..072c480 100644 --- a/scalastyle-config.xml +++ b/scalastyle-config.xml @@ -96,7 +96,7 @@ <!-- <check level="error" class="org.scalastyle.scalariform.ReturnChecker" enabled="true"></check> --> <!-- <check level="error" class="org.scalastyle.scalariform.NullChecker" enabled="true"></check> --> <!-- <check level="error" class="org.scalastyle.scalariform.NoCloneChecker" enabled="true"></check> --> - <!-- <check level="error" class="org.scalastyle.scalariform.NoFinalizeChecker" enabled="true"></check> --> + <check level="error" class="org.scalastyle.scalariform.NoFinalizeChecker" enabled="true"></check> <!-- <check level="error" class="org.scalastyle.scalariform.CovariantEqualsChecker" enabled="true"></check> --> <!-- <check level="error" class="org.scalastyle.scalariform.StructuralTypeChecker" enabled="true"></check> --> <!-- <check level="error" class="org.scalastyle.file.RegexChecker" enabled="true"> --> --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org