Repository: spark
Updated Branches:
  refs/heads/master 67b673208 -> 83653ac5e


[SPARK-10864][WEB UI] app name is hidden if window is resized

Currently the Web UI navbar has a minimum width of 1200px; so if a window is 
resized smaller than that the app name goes off screen. The 1200px width seems 
to have been chosen since it fits the longest example app name without wrapping.

To work with smaller window widths I made the tabs wrap since it looked better 
than wrapping the app name. This is a distinct change in how the navbar looks 
and I'm not sure if it's what we actually want to do.

Other notes:
- min-width set to 600px to keep the tabs from wrapping individually (will need 
to be adjusted if tabs are added)
- app name will also wrap (making three levels) if a really really long app 
name is used

Author: Alex Bozarth <ajboz...@us.ibm.com>

Closes #9874 from ajbozarth/spark10864.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/83653ac5
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/83653ac5
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/83653ac5

Branch: refs/heads/master
Commit: 83653ac5e71996c5a366a42170bed316b208f1b5
Parents: 67b6732
Author: Alex Bozarth <ajboz...@us.ibm.com>
Authored: Wed Nov 25 11:39:00 2015 -0800
Committer: Andrew Or <and...@databricks.com>
Committed: Wed Nov 25 11:39:00 2015 -0800

----------------------------------------------------------------------
 core/src/main/resources/org/apache/spark/ui/static/webui.css | 8 ++------
 core/src/main/scala/org/apache/spark/ui/UIUtils.scala        | 2 +-
 2 files changed, 3 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/83653ac5/core/src/main/resources/org/apache/spark/ui/static/webui.css
----------------------------------------------------------------------
diff --git a/core/src/main/resources/org/apache/spark/ui/static/webui.css 
b/core/src/main/resources/org/apache/spark/ui/static/webui.css
index 04f3070..c628a0c 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/webui.css
+++ b/core/src/main/resources/org/apache/spark/ui/static/webui.css
@@ -16,14 +16,9 @@
  */
 
 .navbar {
-  height: 50px;
   font-size: 15px;
   margin-bottom: 15px;
-  min-width: 1200px
-}
-
-.navbar .navbar-inner {
-  height: 50px;
+  min-width: 600px;
 }
 
 .navbar .brand {
@@ -46,6 +41,7 @@
 .navbar-text {
   height: 50px;
   line-height: 3.3;
+  white-space: nowrap;
 }
 
 table.sortable thead {

http://git-wip-us.apache.org/repos/asf/spark/blob/83653ac5/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/UIUtils.scala 
b/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
index 84a1116..1e8194f 100644
--- a/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
+++ b/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
@@ -210,10 +210,10 @@ private[spark] object UIUtils extends Logging {
                 <span class="version">{org.apache.spark.SPARK_VERSION}</span>
               </a>
             </div>
-            <ul class="nav">{header}</ul>
             <p class="navbar-text pull-right">
               <strong title={appName}>{shortAppName}</strong> application UI
             </p>
+            <ul class="nav">{header}</ul>
           </div>
         </div>
         <div class="container-fluid">


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to