Repository: spark
Updated Branches:
  refs/heads/master fcd013cf7 -> f82ebb152


[SPARK-12368][ML][DOC] Better doc for the binary classification evaluator' 
metricName

For the BinaryClassificationEvaluator, the scaladoc doesn't mention that 
"areaUnderPR" is supported, only that the default is "areadUnderROC".
Also, in the documentation, it is said that:
"The default metric used to choose the best ParamMap can be overriden by the 
setMetric method in each of these evaluators."
However, the method is called setMetricName.

This PR aims to fix both issues.

Author: BenFradet <benjamin.fra...@gmail.com>

Closes #10328 from BenFradet/SPARK-12368.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/f82ebb15
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/f82ebb15
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/f82ebb15

Branch: refs/heads/master
Commit: f82ebb15224ec5375f25f67d598ec3ef1cb65210
Parents: fcd013c
Author: BenFradet <benjamin.fra...@gmail.com>
Authored: Wed Jan 6 12:01:05 2016 -0800
Committer: Joseph K. Bradley <jos...@databricks.com>
Committed: Wed Jan 6 12:01:05 2016 -0800

----------------------------------------------------------------------
 docs/ml-guide.md                                                 | 4 ++--
 .../spark/ml/evaluation/BinaryClassificationEvaluator.scala      | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/f82ebb15/docs/ml-guide.md
----------------------------------------------------------------------
diff --git a/docs/ml-guide.md b/docs/ml-guide.md
index 44a316a..1343753 100644
--- a/docs/ml-guide.md
+++ b/docs/ml-guide.md
@@ -628,7 +628,7 @@ Currently, `spark.ml` supports model selection using the 
[`CrossValidator`](api/
 The `Evaluator` can be a 
[`RegressionEvaluator`](api/scala/index.html#org.apache.spark.ml.evaluation.RegressionEvaluator)
 for regression problems, a 
[`BinaryClassificationEvaluator`](api/scala/index.html#org.apache.spark.ml.evaluation.BinaryClassificationEvaluator)
 for binary data, or a 
[`MultiClassClassificationEvaluator`](api/scala/index.html#org.apache.spark.ml.evaluation.MultiClassClassificationEvaluator)
-for multiclass problems. The default metric used to choose the best `ParamMap` 
can be overriden by the `setMetric`
+for multiclass problems. The default metric used to choose the best `ParamMap` 
can be overriden by the `setMetricName`
 method in each of these evaluators.
 
 The `ParamMap` which produces the best evaluation metric (averaged over the 
`$k$` folds) is selected as the best model.
@@ -951,4 +951,4 @@ model.transform(test)
 {% endhighlight %}
 </div>
 
-</div>
\ No newline at end of file
+</div>

http://git-wip-us.apache.org/repos/asf/spark/blob/f82ebb15/mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala
----------------------------------------------------------------------
diff --git 
a/mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala
 
b/mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala
index bfb7096..f71726f 100644
--- 
a/mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala
+++ 
b/mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala
@@ -39,8 +39,7 @@ class BinaryClassificationEvaluator @Since("1.4.0") 
(@Since("1.4.0") override va
   def this() = this(Identifiable.randomUID("binEval"))
 
   /**
-   * param for metric name in evaluation
-   * Default: areaUnderROC
+   * param for metric name in evaluation (supports `"areaUnderROC"` (default), 
`"areaUnderPR"`)
    * @group param
    */
   @Since("1.2.0")


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to