Repository: spark Updated Branches: refs/heads/branch-1.6 ce906b33d -> 3b32aa9e2
[SPARK-12734][HOTFIX] Build changes must trigger all tests; clean after install in dep tests This patch fixes a build/test issue caused by the combination of #10672 and a latent issue in the original `dev/test-dependencies` script. First, changes which _only_ touched build files were not triggering full Jenkins runs, making it possible for a build change to be merged even though it could cause failures in other tests. The `root` build module now depends on `build`, so all tests will now be run whenever a build-related file is changed. I also added a `clean` step to the Maven install step in `dev/test-dependencies` in order to address an issue where the dummy JARs stuck around and caused "multiple assembly JARs found" errors in tests. /cc zsxwing Author: Josh Rosen <joshro...@databricks.com> Closes #10704 from JoshRosen/fix-build-test-problems. (cherry picked from commit a44991453a43615028083ba9546f5cd93112f6bd) Signed-off-by: Josh Rosen <joshro...@databricks.com> Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/3b32aa9e Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/3b32aa9e Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/3b32aa9e Branch: refs/heads/branch-1.6 Commit: 3b32aa9e29506606d4ca2407aa65a1aab8794805 Parents: ce906b3 Author: Josh Rosen <joshro...@databricks.com> Authored: Mon Jan 11 12:56:43 2016 -0800 Committer: Josh Rosen <joshro...@databricks.com> Committed: Mon Jan 11 12:58:07 2016 -0800 ---------------------------------------------------------------------- dev/sparktestsupport/modules.py | 2 +- dev/test-dependencies.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/3b32aa9e/dev/sparktestsupport/modules.py ---------------------------------------------------------------------- diff --git a/dev/sparktestsupport/modules.py b/dev/sparktestsupport/modules.py index 47cd600..21667d5 100644 --- a/dev/sparktestsupport/modules.py +++ b/dev/sparktestsupport/modules.py @@ -435,7 +435,7 @@ yarn = Module( # No other modules should directly depend on this module. root = Module( name="root", - dependencies=[], + dependencies=[build], # Changes to build should trigger all tests. source_file_regexes=[], # In order to run all of the tests, enable every test profile: build_profile_flags=list(set( http://git-wip-us.apache.org/repos/asf/spark/blob/3b32aa9e/dev/test-dependencies.sh ---------------------------------------------------------------------- diff --git a/dev/test-dependencies.sh b/dev/test-dependencies.sh index 47ae15b..efb49f7 100755 --- a/dev/test-dependencies.sh +++ b/dev/test-dependencies.sh @@ -76,7 +76,7 @@ for HADOOP_PROFILE in "${HADOOP_PROFILES[@]}"; do HADOOP_MODULE_PROFILES="-Phive-thriftserver -Pyarn -Phive" fi echo "Performing Maven install for $HADOOP_PROFILE" - $MVN $HADOOP_MODULE_PROFILES -P$HADOOP_PROFILE jar:jar jar:test-jar install:install -q + $MVN $HADOOP_MODULE_PROFILES -P$HADOOP_PROFILE jar:jar jar:test-jar install:install clean -q echo "Performing Maven validate for $HADOOP_PROFILE" $MVN $HADOOP_MODULE_PROFILES -P$HADOOP_PROFILE validate -q --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
