Repository: spark Updated Branches: refs/heads/master cef77d1f6 -> e66afd5c6
[SPARK-14875][SQL] Makes OutputWriterFactory.newInstance public ## What changes were proposed in this pull request? This method was accidentally made `private[sql]` in Spark 2.0. This PR makes it public again, since 3rd party data sources like spark-avro depend on it. ## How was this patch tested? N/A Author: Cheng Lian <l...@databricks.com> Closes #12652 from liancheng/spark-14875. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/e66afd5c Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/e66afd5c Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/e66afd5c Branch: refs/heads/master Commit: e66afd5c66a6d8f33c90ce08c35c3823735bde83 Parents: cef77d1 Author: Cheng Lian <l...@databricks.com> Authored: Mon Apr 25 20:42:49 2016 +0800 Committer: Cheng Lian <l...@databricks.com> Committed: Mon Apr 25 20:42:49 2016 +0800 ---------------------------------------------------------------------- .../spark/sql/execution/datasources/fileSourceInterfaces.scala | 2 +- .../scala/org/apache/spark/sql/sources/SimpleTextRelation.scala | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/e66afd5c/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala ---------------------------------------------------------------------- diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala index ed24bdd..4063c6e 100644 --- a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala +++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/fileSourceInterfaces.scala @@ -59,7 +59,7 @@ abstract class OutputWriterFactory extends Serializable { * @param context The Hadoop MapReduce task context. * @since 1.4.0 */ - private[sql] def newInstance( + def newInstance( path: String, bucketId: Option[Int], // TODO: This doesn't belong here... dataSchema: StructType, http://git-wip-us.apache.org/repos/asf/spark/blob/e66afd5c/sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala ---------------------------------------------------------------------- diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala b/sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala index 16996ae..dad4f87 100644 --- a/sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala +++ b/sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala @@ -48,7 +48,7 @@ class SimpleTextSource extends FileFormat with DataSourceRegister { job: Job, options: Map[String, String], dataSchema: StructType): OutputWriterFactory = new OutputWriterFactory { - override private[sql] def newInstance( + override def newInstance( path: String, bucketId: Option[Int], dataSchema: StructType, --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org