Repository: spark
Updated Branches:
  refs/heads/master 5cb03220a -> 2a3d39f48


[MINOR] Follow-up to #12625

## What changes were proposed in this pull request?

That patch mistakenly widened the visibility from `private[x]` to 
`protected[x]`. This patch reverts those changes.

Author: Andrew Or <and...@databricks.com>

Closes #12686 from andrewor14/visibility.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/2a3d39f4
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/2a3d39f4
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/2a3d39f4

Branch: refs/heads/master
Commit: 2a3d39f48b1a7bb462e17e80e243bbc0a94d802e
Parents: 5cb0322
Author: Andrew Or <and...@databricks.com>
Authored: Tue Apr 26 11:08:08 2016 -0700
Committer: Andrew Or <and...@databricks.com>
Committed: Tue Apr 26 11:08:08 2016 -0700

----------------------------------------------------------------------
 .../src/main/scala/org/apache/spark/ml/clustering/LDA.scala  | 8 ++++----
 .../main/scala/org/apache/spark/sql/DataFrameReader.scala    | 2 +-
 sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala   | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/2a3d39f4/mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala
----------------------------------------------------------------------
diff --git a/mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala 
b/mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala
index 27c813d..1554d56 100644
--- a/mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala
+++ b/mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala
@@ -360,10 +360,10 @@ private[clustering] trait LDAParams extends Params with 
HasFeaturesCol with HasM
  */
 @Since("1.6.0")
 @Experimental
-sealed abstract class LDAModel protected[ml] (
+sealed abstract class LDAModel private[ml] (
     @Since("1.6.0") override val uid: String,
     @Since("1.6.0") val vocabSize: Int,
-    @Since("1.6.0") @transient protected[ml] val sparkSession: SparkSession)
+    @Since("1.6.0") @transient private[ml] val sparkSession: SparkSession)
   extends Model[LDAModel] with LDAParams with Logging with MLWritable {
 
   // NOTE to developers:
@@ -512,7 +512,7 @@ sealed abstract class LDAModel protected[ml] (
  */
 @Since("1.6.0")
 @Experimental
-class LocalLDAModel protected[ml] (
+class LocalLDAModel private[ml] (
     uid: String,
     vocabSize: Int,
     @Since("1.6.0") override protected val oldLocalModel: OldLocalLDAModel,
@@ -604,7 +604,7 @@ object LocalLDAModel extends MLReadable[LocalLDAModel] {
  */
 @Since("1.6.0")
 @Experimental
-class DistributedLDAModel protected[ml] (
+class DistributedLDAModel private[ml] (
     uid: String,
     vocabSize: Int,
     private val oldDistributedModel: OldDistributedLDAModel,

http://git-wip-us.apache.org/repos/asf/spark/blob/2a3d39f4/sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala 
b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
index b49cda3..3d43f20 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
@@ -41,7 +41,7 @@ import org.apache.spark.sql.types.StructType
  * @since 1.4.0
  */
 @Experimental
-class DataFrameReader protected[sql](sparkSession: SparkSession) extends 
Logging {
+class DataFrameReader private[sql](sparkSession: SparkSession) extends Logging 
{
 
   /**
    * Specifies the input data source format.

http://git-wip-us.apache.org/repos/asf/spark/blob/2a3d39f4/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala 
b/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
index 4c2bf12..bcb3fdb 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
@@ -151,7 +151,7 @@ private[sql] object Dataset {
  *
  * @since 1.6.0
  */
-class Dataset[T] protected[sql](
+class Dataset[T] private[sql](
     @transient val sparkSession: SparkSession,
     @DeveloperApi @transient val queryExecution: QueryExecution,
     encoder: Encoder[T])


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to