Repository: spark Updated Branches: refs/heads/branch-2.0 0cde3ad6d -> 76d0ef34e
[MINOR][MLLIB] DefaultParamsReadable/Writable should be DeveloperApi ## What changes were proposed in this pull request? `DefaultParamsReadable/Writable` are not user-facing. Only developers who implement `Transformer/Estimator` would use it. So this PR changes the annotation to `DeveloperApi`. Author: Xiangrui Meng <m...@databricks.com> Closes #13828 from mengxr/default-readable-should-be-developer-api. (cherry picked from commit 6a6010f0015542dc2753b2cb12fdd1204db63ea6) Signed-off-by: Xiangrui Meng <m...@databricks.com> Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/76d0ef34 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/76d0ef34 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/76d0ef34 Branch: refs/heads/branch-2.0 Commit: 76d0ef34e4a5b91b883141f839adc493205fa429 Parents: 0cde3ad Author: Xiangrui Meng <m...@databricks.com> Authored: Wed Jun 22 10:06:43 2016 -0700 Committer: Xiangrui Meng <m...@databricks.com> Committed: Wed Jun 22 10:06:49 2016 -0700 ---------------------------------------------------------------------- .../scala/org/apache/spark/ml/util/ReadWrite.scala | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/76d0ef34/mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala ---------------------------------------------------------------------- diff --git a/mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala b/mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala index 1582a73..4413fef 100644 --- a/mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala +++ b/mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala @@ -26,7 +26,7 @@ import org.json4s.JsonDSL._ import org.json4s.jackson.JsonMethods._ import org.apache.spark.SparkContext -import org.apache.spark.annotation.{Experimental, Since} +import org.apache.spark.annotation.{DeveloperApi, Experimental, Since} import org.apache.spark.internal.Logging import org.apache.spark.ml._ import org.apache.spark.ml.classification.{OneVsRest, OneVsRestModel} @@ -161,7 +161,7 @@ trait MLWritable { } /** - * :: Experimental :: + * :: DeveloperApi :: * * Helper trait for making simple [[Params]] types writable. If a [[Params]] class stores * all data as [[org.apache.spark.ml.param.Param]] values, then extending this trait will provide @@ -171,8 +171,7 @@ trait MLWritable { * * @see [[DefaultParamsReadable]], the counterpart to this trait */ -@Experimental -@Since("2.0.0") +@DeveloperApi trait DefaultParamsWritable extends MLWritable { self: Params => override def write: MLWriter = new DefaultParamsWriter(this) @@ -230,7 +229,7 @@ trait MLReadable[T] { /** - * :: Experimental :: + * :: DeveloperApi :: * * Helper trait for making simple [[Params]] types readable. If a [[Params]] class stores * all data as [[org.apache.spark.ml.param.Param]] values, then extending this trait will provide @@ -239,11 +238,9 @@ trait MLReadable[T] { * [[org.apache.spark.sql.Dataset]]. * * @tparam T ML instance type - * * @see [[DefaultParamsWritable]], the counterpart to this trait */ -@Experimental -@Since("2.0.0") +@DeveloperApi trait DefaultParamsReadable[T] extends MLReadable[T] { override def read: MLReader[T] = new DefaultParamsReader[T] --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
