Repository: spark Updated Branches: refs/heads/master 0b0c8b95e -> 928ca1c6d
[SPARK-17102][SQL] bypass UserDefinedGenerator for json format check ## What changes were proposed in this pull request? We use reflection to convert `TreeNode` to json string, and currently don't support arbitrary object. `UserDefinedGenerator` takes a function object, so we should skip json format test for it, or the tests can be flacky, e.g. `DataFrameSuite.simple explode`, this test always fail with scala 2.10(branch 1.6 builds with scala 2.10 by default), but pass with scala 2.11(master branch builds with scala 2.11 by default). ## How was this patch tested? N/A Author: Wenchen Fan <wenc...@databricks.com> Closes #14679 from cloud-fan/json. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/928ca1c6 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/928ca1c6 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/928ca1c6 Branch: refs/heads/master Commit: 928ca1c6d12b23d84f9b6205e22d2e756311f072 Parents: 0b0c8b9 Author: Wenchen Fan <wenc...@databricks.com> Authored: Wed Aug 17 09:31:22 2016 -0700 Committer: Yin Huai <yh...@databricks.com> Committed: Wed Aug 17 09:31:22 2016 -0700 ---------------------------------------------------------------------- sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/928ca1c6/sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala ---------------------------------------------------------------------- diff --git a/sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala b/sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala index cff9d22..484e438 100644 --- a/sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala +++ b/sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala @@ -249,9 +249,10 @@ abstract class QueryTest extends PlanTest { } p }.transformAllExpressions { - case a: ImperativeAggregate => return + case _: ImperativeAggregate => return case _: TypedAggregateExpression => return case Literal(_, _: ObjectType) => return + case _: UserDefinedGenerator => return } // bypass hive tests before we fix all corner cases in hive module. --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
