Repository: spark Updated Branches: refs/heads/branch-2.1 491db67a5 -> 707630147
[SPARK-17710][FOLLOW UP] Add comments to state why 'Utils.classForName' is not used ## What changes were proposed in this pull request? Add comments. ## How was this patch tested? Build passed. Author: Weiqing Yang <yangweiqing...@gmail.com> Closes #15776 from weiqingy/SPARK-17710. (cherry picked from commit 8a9ca1924792d1a7c733bdfd757996b3ade0d63d) Signed-off-by: Reynold Xin <r...@databricks.com> Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/70763014 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/70763014 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/70763014 Branch: refs/heads/branch-2.1 Commit: 707630147e51114aa90f58f375df43bb2b5f7fb4 Parents: 491db67 Author: Weiqing Yang <yangweiqing...@gmail.com> Authored: Fri Nov 4 23:44:46 2016 -0700 Committer: Reynold Xin <r...@databricks.com> Committed: Fri Nov 4 23:44:53 2016 -0700 ---------------------------------------------------------------------- core/src/main/scala/org/apache/spark/util/Utils.scala | 4 ++++ 1 file changed, 4 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/70763014/core/src/main/scala/org/apache/spark/util/Utils.scala ---------------------------------------------------------------------- diff --git a/core/src/main/scala/org/apache/spark/util/Utils.scala b/core/src/main/scala/org/apache/spark/util/Utils.scala index 22c28fb..1de66af 100644 --- a/core/src/main/scala/org/apache/spark/util/Utils.scala +++ b/core/src/main/scala/org/apache/spark/util/Utils.scala @@ -2539,6 +2539,8 @@ private[util] object CallerContext extends Logging { val callerContextSupported: Boolean = { SparkHadoopUtil.get.conf.getBoolean("hadoop.caller.context.enabled", false) && { try { + // `Utils.classForName` will make `ReplSuite` fail with `ClassCircularityError` in + // master Maven build, so do not use it before resolving SPARK-17714. // scalastyle:off classforname Class.forName("org.apache.hadoop.ipc.CallerContext") Class.forName("org.apache.hadoop.ipc.CallerContext$Builder") @@ -2604,6 +2606,8 @@ private[spark] class CallerContext( def setCurrentContext(): Unit = { if (CallerContext.callerContextSupported) { try { + // `Utils.classForName` will make `ReplSuite` fail with `ClassCircularityError` in + // master Maven build, so do not use it before resolving SPARK-17714. // scalastyle:off classforname val callerContext = Class.forName("org.apache.hadoop.ipc.CallerContext") val builder = Class.forName("org.apache.hadoop.ipc.CallerContext$Builder") --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
