Repository: spark Updated Branches: refs/heads/master b7304f255 -> b36ce2a24
[SPARK-21064][CORE][TEST] Fix the default value bug in NettyBlockTransferServiceSuite ## What changes were proposed in this pull request? The default value for `spark.port.maxRetries` is 100, but we use 10 in the suite file. So we change it to 100 to avoid test failure. ## How was this patch tested? No test Author: DjvuLee <l...@bytedance.com> Closes #18280 from djvulee/NettyTestBug. Project: http://git-wip-us.apache.org/repos/asf/spark/repo Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/b36ce2a2 Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/b36ce2a2 Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/b36ce2a2 Branch: refs/heads/master Commit: b36ce2a2469ff923a3367a530d4a14899ecf9238 Parents: b7304f2 Author: DjvuLee <l...@bytedance.com> Authored: Tue Jun 13 15:56:03 2017 +0100 Committer: Sean Owen <so...@cloudera.com> Committed: Tue Jun 13 15:56:03 2017 +0100 ---------------------------------------------------------------------- .../spark/network/netty/NettyBlockTransferServiceSuite.scala | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/spark/blob/b36ce2a2/core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala ---------------------------------------------------------------------- diff --git a/core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala b/core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala index 271ab8b..9825930 100644 --- a/core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala +++ b/core/src/test/scala/org/apache/spark/network/netty/NettyBlockTransferServiceSuite.scala @@ -80,7 +80,8 @@ class NettyBlockTransferServiceSuite private def verifyServicePort(expectedPort: Int, actualPort: Int): Unit = { actualPort should be >= expectedPort // avoid testing equality in case of simultaneous tests - actualPort should be <= (expectedPort + 10) + // the default value for `spark.port.maxRetries` is 100 under test + actualPort should be <= (expectedPort + 100) } private def createService(port: Int): NettyBlockTransferService = { --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org
