Repository: spark
Updated Branches:
  refs/heads/master 945240193 -> d766ea2ff


[SPARK-23861][SQL][DOC] Clarify default window frame with and without orderBy 
clause

## What changes were proposed in this pull request?

Add docstring to clarify default window frame boundaries with and without 
orderBy clause

## How was this patch tested?

Manually generate doc and check.

Author: Li Jin <ice.xell...@gmail.com>

Closes #20978 from icexelloss/SPARK-23861-window-doc.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/d766ea2f
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/d766ea2f
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/d766ea2f

Branch: refs/heads/master
Commit: d766ea2ff2bf59afbd631d3cc2e43bebfccdebed
Parents: 9452401
Author: Li Jin <ice.xell...@gmail.com>
Authored: Sat Apr 7 00:15:54 2018 +0800
Committer: hyukjinkwon <gurwls...@apache.org>
Committed: Sat Apr 7 00:15:54 2018 +0800

----------------------------------------------------------------------
 python/pyspark/sql/window.py                                     | 4 ++++
 .../src/main/scala/org/apache/spark/sql/expressions/Window.scala | 4 ++++
 2 files changed, 8 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/d766ea2f/python/pyspark/sql/window.py
----------------------------------------------------------------------
diff --git a/python/pyspark/sql/window.py b/python/pyspark/sql/window.py
index e667fba..d19ced9 100644
--- a/python/pyspark/sql/window.py
+++ b/python/pyspark/sql/window.py
@@ -44,6 +44,10 @@ class Window(object):
     >>> # PARTITION BY country ORDER BY date RANGE BETWEEN 3 PRECEDING AND 3 
FOLLOWING
     >>> window = 
Window.orderBy("date").partitionBy("country").rangeBetween(-3, 3)
 
+    .. note:: When ordering is not defined, an unbounded window frame 
(rowFrame,
+         unboundedPreceding, unboundedFollowing) is used by default. When 
ordering is defined,
+         a growing window frame (rangeFrame, unboundedPreceding, currentRow) 
is used by default.
+
     .. note:: Experimental
 
     .. versionadded:: 1.4

http://git-wip-us.apache.org/repos/asf/spark/blob/d766ea2f/sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala
----------------------------------------------------------------------
diff --git 
a/sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala 
b/sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala
index 1caa243..cd819ba 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala
@@ -33,6 +33,10 @@ import org.apache.spark.sql.catalyst.expressions._
  *   Window.partitionBy("country").orderBy("date").rowsBetween(-3, 3)
  * }}}
  *
+ * @note When ordering is not defined, an unbounded window frame (rowFrame, 
unboundedPreceding,
+ *       unboundedFollowing) is used by default. When ordering is defined, a 
growing window frame
+ *       (rangeFrame, unboundedPreceding, currentRow) is used by default.
+ *
  * @since 1.4.0
  */
 @InterfaceStability.Stable


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org

Reply via email to