This is an automated email from the ASF dual-hosted git repository. srowen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push: new ec11790 [CORE][MINOR] Correct the comment to show heartbeat interval is configurable ec11790 is described below commit ec1179058071a9ad9bfea0878c42aa81e4cbce58 Author: SongYadong <song.yado...@zte.com.cn> AuthorDate: Fri Mar 15 20:30:36 2019 -0500 [CORE][MINOR] Correct the comment to show heartbeat interval is configurable ## What changes were proposed in this pull request? Executor heartbeat interval is configurable by `"spark.executor.heartbeatInterval"`. But in a comment, heartbeat interval is presented as a constant `10s`. This pr tries to correct the description. ## How was this patch tested? Existing unit tests. Closes #24101 from SongYadong/heartbeat_interval_comment. Authored-by: SongYadong <song.yado...@zte.com.cn> Signed-off-by: Sean Owen <sean.o...@databricks.com> --- core/src/main/scala/org/apache/spark/executor/Executor.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/scala/org/apache/spark/executor/Executor.scala b/core/src/main/scala/org/apache/spark/executor/Executor.scala index 740080e..d597315 100644 --- a/core/src/main/scala/org/apache/spark/executor/Executor.scala +++ b/core/src/main/scala/org/apache/spark/executor/Executor.scala @@ -175,8 +175,8 @@ private[spark] class Executor( /** * When an executor is unable to send heartbeats to the driver more than `HEARTBEAT_MAX_FAILURES` - * times, it should kill itself. The default value is 60. It means we will retry to send - * heartbeats about 10 minutes because the heartbeat interval is 10s. + * times, it should kill itself. The default value is 60. For example, if max failures is 60 and + * heartbeat interval is 10s, then it will try to send heartbeats for up to 600s (10 minutes). */ private val HEARTBEAT_MAX_FAILURES = conf.get(EXECUTOR_HEARTBEAT_MAX_FAILURES) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org For additional commands, e-mail: commits-h...@spark.apache.org