[spark] branch branch-2.4 updated: [SPARK-28775][CORE][TESTS] Skip date 8633 in Kwajalein due to changes in tzdata2018i that only some JDK 8s use

[dongjoon]

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-2.4 by this push:
     new 7e4825c  [SPARK-28775][CORE][TESTS] Skip date 8633 in Kwajalein due to 
changes in tzdata2018i that only some JDK 8s use
7e4825c is described below

commit 7e4825c743c38af69ca66ae8dc37e807085be3a7
Author: Sean Owen <sean.o...@databricks.com>
AuthorDate: Mon Aug 19 17:54:25 2019 -0700

    [SPARK-28775][CORE][TESTS] Skip date 8633 in Kwajalein due to changes in 
tzdata2018i that only some JDK 8s use
    
    ### What changes were proposed in this pull request?
    
    Some newer JDKs use the tzdata2018i database, which changes how certain 
(obscure) historical dates and timezones are handled. As previously, we can 
pretty much safely ignore these in tests, as the value may vary by JDK.
    
    ### Why are the changes needed?
    
    Test otherwise fails using, for example, JDK 1.8.0_222. 
https://bugs.openjdk.java.net/browse/JDK-8215982 has a full list of JDKs which 
has this.
    
    ### Does this PR introduce any user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    Existing tests
    
    Closes #25504 from srowen/SPARK-28775.
    
    Authored-by: Sean Owen <sean.o...@databricks.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
    (cherry picked from commit 3b4e345fa1afa0d4004988f8800b63150c305fd4)
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 .../scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
 
b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
index 5989a17..abdb916 100644
--- 
a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
+++ 
b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
@@ -669,12 +669,12 @@ class DateTimeUtilsSuite extends SparkFunSuite {
 
     // There are some days are skipped entirely in some timezone, skip them 
here.
     val skipped_days = Map[String, Set[Int]](
-      "Kwajalein" -> Set(8632),
+      "Kwajalein" -> Set(8632, 8633),
       "Pacific/Apia" -> Set(15338),
       "Pacific/Enderbury" -> Set(9130, 9131),
       "Pacific/Fakaofo" -> Set(15338),
       "Pacific/Kiritimati" -> Set(9130, 9131),
-      "Pacific/Kwajalein" -> Set(8632),
+      "Pacific/Kwajalein" -> Set(8632, 8633),
       "MIT" -> Set(15338))
     for (tz <- DateTimeTestUtils.ALL_TIMEZONES) {
       val skipped = skipped_days.getOrElse(tz.getID, Set.empty)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org