This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 6c6283b [SPARK-31564][TESTS] Fix flaky AllExecutionsPageSuite for
checking 1970
6c6283b is described below
commit 6c6283b1e68b174b212f3352b1496ab9e92450ad
Author: Kent Yao <yaooq...@hotmail.com>
AuthorDate: Sat Apr 25 10:27:05 2020 -0700
[SPARK-31564][TESTS] Fix flaky AllExecutionsPageSuite for checking 1970
### What changes were proposed in this pull request?
Fix flakiness by checking `1970/01/01` instead of `1970`.
The test was added by SPARK-27125 for 3.0.0.
### Why are the changes needed?
the
`org.apache.spark.sql.execution.ui.AllExecutionsPageSuite.SPARK-27019:correctly
display SQL page when event reordering happens` test is flaky for just checking
the `html` content not containing 1970. I will add a ticket to check and fix
that.
In the specific failure
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121799/testReport,
it failed because the `html`
```
...
<td sorttable_customkey="1587806019707">
...
```
contained `1970`.
### Does this PR introduce any user-facing change?
no
### How was this patch tested?
passing jenkins
Closes #28344 from yaooqinn/SPARK-31564.
Authored-by: Kent Yao <yaooq...@hotmail.com>
Signed-off-by: Dongjoon Hyun <dongj...@apache.org>
(cherry picked from commit 7959808e962584704cba1ed26a4bcece724424d5)
Signed-off-by: Dongjoon Hyun <dongj...@apache.org>
---
.../org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala
b/sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala
index 298afa8..24b8a97 100644
---
a/sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala
+++
b/sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala
@@ -57,7 +57,7 @@ class AllExecutionsPageSuite extends SharedSparkSession with
BeforeAndAfter {
val html = renderSQLPage(request, tab,
statusStore).toString().toLowerCase(Locale.ROOT)
assert(html.contains("failed queries"))
- assert(!html.contains("1970"))
+ assert(!html.contains("1970/01/01"))
}
test("sorting should be successful") {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
